Re: windows/clipboard.c: Get rid of W->A calls

2005-01-08 Thread Dmitry Timoshkov
"Jacek Caban" <[EMAIL PROTECTED]> wrote: > @@ -310,15 +335,24 @@ static void intern_atoms(void) > names = HeapAlloc( GetProcessHeap(), 0, count * sizeof(*names) ); > atoms = HeapAlloc( GetProcessHeap(), 0, count * sizeof(*atoms) ); > > -for (format = ClipFormats, i = 0; format; for

Re: Get rid of W->A calls : help me help ?

2004-08-25 Thread James Hawkins
Hey Joris, I would be glad to write a howto for your and possibly others. I will get started on that soon. On 25 Aug 2004 11:43:57 -0400, Vincent Béron <[EMAIL PROTECTED]> wrote: > Le mer 25/08/2004 à 11:27, Joris Huizer a écrit : > [snip] > > Hi James, > > > > Yeah I would like that, thanks for

Re: Get rid of W->A calls : help me help ?

2004-08-25 Thread Vincent Béron
Le mer 25/08/2004 à 11:27, Joris Huizer a écrit : [snip] > Hi James, > > Yeah I would like that, thanks for suggesting :) > I'll try and do a search on unicode functions and stuff but -- well, you > have seen more of wine specific details ... > > Also, I think it'd be smart to put something like

Re: Get rid of W->A calls : help me help ?

2004-08-25 Thread Joris Huizer
James Hawkins wrote: Hey Joris, I started developing wine in exactly the same way you are starting: working on the janitorial projects. My current project is converting the crypt cross calls, and it is almost finished, but im waiting for my CryptSetProviderExA patch to be committed before I se

Re: Get rid of W->A calls : help me help ?

2004-08-25 Thread James Hawkins
Hey Joris, I started developing wine in exactly the same way you are starting: working on the janitorial projects. My current project is converting the crypt cross calls, and it is almost finished, but im waiting for my CryptSetProviderExA patch to be committed before I send the rest of my cr

Re: Get rid of W->A calls : help me help ?

2004-08-25 Thread Mike Hearn
Joris Huizer wrote: Hello, I'm thinking of trying to do some helpfull work on wine; Cool! I have the following problem, - I don't know where to start (I have never done stuff in wine or another open source project) ; but I hope you have patience to guide me into that (but I'm a informatica studen

Get rid of W->A calls : help me help ?

2004-08-25 Thread Joris Huizer
Hello, I'm thinking of trying to do some helpfull work on wine; I have the following problem, - I don't know where to start (I have never done stuff in wine or another open source project) ; but I hope you have patience to guide me into that (but I'm a informatica student, I like learning stuff l

Re: Janitorial: Get rid of W->A calls for shlexec [RESEND]

2004-01-14 Thread Marcelo Duarte
. Em Sáb 10 Jan 2004 04:51, Marcelo Duarte escreveu: > Updated with the lastest cvs. > > Changelog: > Marcelo Duarte <[EMAIL PROTECTED]> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW -- Marcelo Duarte

Re: Janitorial: Get rid of W->A calls for shlexec (2/2)

2003-12-11 Thread Alexandre Julliard
Marcelo Duarte <[EMAIL PROTECTED]> writes: > Hi, > > Changelog: > Marcelo Duarte <[EMAIL PROTECTED]> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW > > Coments: > After you aplying my patch 1/2 and made corrections

Janitorial: Get rid of W->A calls for metafiles

2003-11-08 Thread Vincent Béron
Not 100% about the part changing METAHEADERDISK.filename type. Can apps access it directly and barf if they find WCHAR instead of CHAR? And is the length set to 0x100 for binary compatibility? Changelog: Get rid of W->A calls for metafiles. Vincent Index: dlls/gdi/mfdrv/ini

Re: WIne help - get rid of W->A calls

2003-09-12 Thread Dimitrie O. Paun
On Fri, 12 Sep 2003, hatky wrote: > Do you mean the conver of lpHelpFile in WinHelpA > before it calls WinHelpW? It means that somehow you picked another tricky example to work on :) WinHelp is a very special API in that it does some fucky/ugly stuff to pass data between apps. I'd do another on

Re: WIne help - get rid of W->A calls

2003-09-12 Thread hatky
> ASCII, I'd suggest > keeping the encoding of strings inside the message > as ASCII. Do you mean the conver of lpHelpFile in WinHelpA before it calls WinHelpW? p.s. sorry I didn't find time for this doing the week Hatky. __ Do you Yahoo!? Yahoo! SiteBuilder - F

Re: WIne help - get rid of W->A calls

2003-09-05 Thread Eric Pouech
hatky wrote: My first patch, so a deep check is welcome Change log: - Remove W->A call from WineHelpA/W - This patch is dedicated to dimi that guided me I'm afraid the patch is wrong. the current implentation of WinHelp, which sends data from any app to the program winhelp, requires that

Re: Get rid of W->A calls

2003-09-05 Thread Rolf Kalbermatter
[EMAIL PROTECTED] wrote: > Ok, one last line: > >strcpy(((char*)lpwh) + sizeof(WINHELP), lpHelpFile); I'm also not sure about the context here and it seems a little strange but what you would want to do here is probably: strcpyW((LPWSTR)((char*)lpwh + sizeof(WINHELP)), lpHelpFile);

Re: Get rid of W->A calls

2003-09-05 Thread Eric Pouech
hatky wrote: Ok, one last line: strcpy(((char*)lpwh) + sizeof(WINHELP), lpHelpFile); I do not realy get what it means (but I know it shouldn't be this way becouse I get a warning: passing arg 1 of `strcpy' from incompatible pointer type lpHelpFile is a LPCWSTR unicode variable and lpw

Re: Get rid of W->A calls

2003-09-05 Thread Dimitrie O. Paun
On Fri, 5 Sep 2003, hatky wrote: > Ok, one last line: > > strcpy(((char*)lpwh) + sizeof(WINHELP), > lpHelpFile); I don't have time now to look at the code, but this is rather strange, I think you want this: strcpyW((LPWSTR)(((char*)lpwh) + sizeof(WINHELP), lpHelpFile); -- Dimi

Re: Get rid of W->A calls

2003-09-05 Thread hatky
> passing arg 1 of `strcpy' from incompatible pointer > type Sorry I ment trying strcpyW gets ../../windows/winhelp.c:167: warning: passing arg 1 of `strcpyW' from incompatible pointer type and strcpy gets ../../windows/winhelp.c:167: warning: passing arg 2 of `strcpy' from incompatible pointer

Re: Get rid of W->A calls

2003-09-05 Thread hatky
Ok, one last line: strcpy(((char*)lpwh) + sizeof(WINHELP), lpHelpFile); I do not realy get what it means (but I know it shouldn't be this way becouse I get a warning: passing arg 1 of `strcpy' from incompatible pointer type lpHelpFile is a LPCWSTR unicode variable and lpwh is of t

Re: Get rid of W->A calls

2003-09-05 Thread Dimitrie O. Paun
On Fri, 5 Sep 2003, hatky wrote: > So should I make it uCommand as in msdn or leave it > wcommand? I'd change both to uCommand as per msdn. > > WCHAR clsName[] = { 'M', 'S', '_', 'W', 'I', > > 'N', 'H', 'E', 'L', 'P', 0 }; > > hDest = FindWindowW(clsName, NULL); Don't forget Robert's ad

Re: Get rid of W->A calls

2003-09-05 Thread hatky
> OK, I have to warn you I haven't looked at the code, > so I'll just go by what I see in this email. That's what I was expecting so I checked it carfully and copied what seems to mater + I know that if/when I will submit the patch it will be checked more... > > why did they call them wcommand in

RE: Get rid of W->A calls

2003-09-05 Thread Robert Shearman
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Behalf Of Dimitrie O. Paun > Sent: 05 September 2003 17:40 > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: Re: Get rid of W->A calls > > > why did they call them wcomma

Re: Get rid of W->A calls

2003-09-05 Thread Dimitrie O. Paun
On Fri, 5 Sep 2003, hatky wrote: > Ok, lets take another one, winhelp.c WinHelpW->A OK, I have to warn you I haven't looked at the code, so I'll just go by what I see in this email. > I take whatever is in WinHelpA and move it into > WinHelpW with the fallowing changes: > > -BOOL WINAPI WinHelp

Re: Get rid of W->A calls

2003-09-05 Thread hatky
> Because I'm a lousy teacher :) Also, it is more > productive > to start with simpler examples, so you also do part > of the > learning from experience. grr. Ok, lets take another one, winhelp.c WinHelpW->A I take whatever is in WinHelpA and move it into WinHelpW with the fallowing changes:

Re: Get rid of W->A calls

2003-09-05 Thread Dimitrie O. Paun
On Fri, 5 Sep 2003, hatky wrote: > I am getting the felling this will repeat, why not > just teach me? Because I'm a lousy teacher :) Also, it is more productive to start with simpler examples, so you also do part of the learning from experience. -- Dimi.

Re: Get rid of W->A calls

2003-09-05 Thread hatky
> You've picked a wrong one to do -- this one is a bit > trickier, because of the callback, and because we > store information internally as ASCII. Do another > one > instead, leave this one for now. I am getting the felling this will repeat, why not just teach me? Hatky. ___

Re: Get rid of W->A calls

2003-09-05 Thread Dimitrie O. Paun
On Fri, 5 Sep 2003, hatky wrote: > > Let us know if you need any help. > > Just to be sure I got it right, I moved the > DirectDrawEnumerateExA stuff into > DirectDrawEnumerateExW since there is nothing ascii or > unicode specific in it I think it's ok on it's own now > in DirectDrawEnumerateExA

Re: Get rid of W->A calls

2003-09-05 Thread hatky
> Let us know if you need any help. Just to be sure I got it right, I moved the DirectDrawEnumerateExA stuff into DirectDrawEnumerateExW since there is nothing ascii or unicode specific in it I think it's ok on it's own now in DirectDrawEnumerateExA I have these variables: LPDDENUMCALLBACKEXA lp

Re: Get rid of W->A calls

2003-09-05 Thread Dimitrie O. Paun
On Fri, 5 Sep 2003, hatky wrote: > What sould I do? > 1. copy the entire DirectDrawEnumerateExA into it > 2. create a 3rd function DirectDrawEnumerateEx that > both of them will call > 3. somthing else (you tell me) It's not always the same answer. Most of the time, you do 3. xxxA converts its

Re: Get rid of W->A calls

2003-09-05 Thread Vincent Béron
Le ven 05/09/2003 à 09:41, hatky a écrit : > Janitorial reporting ;-) > > In the Get rid of W->A calls task, > Say I try > dlls/ddraw/main.c: ddraw: DirectDrawEnumerateExW: > illegal call to DirectDrawEnumerateExA > > The misbheaving function is : > > HRES

Get rid of W->A calls

2003-09-05 Thread hatky
Janitorial reporting ;-) In the Get rid of W->A calls task, Say I try dlls/ddraw/main.c: ddraw: DirectDrawEnumerateExW: illegal call to DirectDrawEnumerateExA The misbheaving function is : HRESULT WINAPI DirectDrawEnumerateExW( LPDDENUMCALLBACKEXW lpCallback, LPVOID lpContext, DWORD dwFl