Re: Functions that should be static

2009-01-08 Thread Juan Lang
> dlls/iphlpapi/ifenum.c: getInterfaceEntryByIndex() This one's definitely dead, go ahead and remove it. Thanks, --Juan

Re: Functions that should be static

2009-01-08 Thread Andrew Talbot
Francois Gouget wrote: > > Thanks for the help with this task. With the last round of patches we > are now down to about 280 warnings so there's definite progress. Here's > the updated list: > > [...] Here are the apparently unused functions I have encountered in the dlls so far. Please speak u

Re: Functions that should be static

2009-01-08 Thread Francois Gouget
Thanks for the help with this task. With the last round of patches we are now down to about 280 warnings so there's definite progress. Here's the updated list: dlls/cabinet/fdi.o: make_decode_table should be made static dlls/cabinet/fdi.o: QTMupdatemodel should be made static dlls/comctl32/test

Re: Functions that should be static

2009-01-06 Thread Francois Gouget
On Sun, 21 Dec 2008, Andrew Talbot wrote: [...] > The dlls/advapi32/svcctl_c.c: svcctl_*() functions are peculiar, too. They > look like they need to be exported in some manner. My script already detects that svcctl_c.c was generated from svcctl.idl and thus won't complain about any of the functi

Re: Functions that should be static

2009-01-06 Thread Francois Gouget
On Sun, 21 Dec 2008, Kai Blin wrote: > On Thursday 18 December 2008 10:09:02 Francois Gouget wrote: > > > dlls/secur32/secur32.dll.so: SECUR32_initNegotiateSP > > This function would (and at some point did) register the Negotiate security > provider. It's not called right now because the provid

Re: Functions that should be static

2008-12-22 Thread Christian Costa
Francois Gouget a écrit : > On Sat, 20 Dec 2008, Christian Costa wrote: > [...] > >> If you have a class A (with methods implemented in file 1) that inherits from >> another class B (methods in file B). >> The class A may overrides some methods of B which may become unused if B is >> never insta

Re: Functions that should be static

2008-12-21 Thread Andrew Talbot
Francois Gouget wrote: > > I have attached a script that identifies functions that should be made > static (among other things). There are approximately 450 of them, there > should be pretty efw false positives, and I will look into them > eventually. But if someone beats me to it I sure won't co

Re: Functions that should be static

2008-12-21 Thread Kai Blin
On Thursday 18 December 2008 10:09:02 Francois Gouget wrote: > dlls/secur32/secur32.dll.so: SECUR32_initNegotiateSP This function would (and at some point did) register the Negotiate security provider. It's not called right now because the provider is not implemented and registering it broke so

Re: Functions that should be static

2008-12-20 Thread Francois Gouget
On Sat, 20 Dec 2008, Christian Costa wrote: [...] > If you have a class A (with methods implemented in file 1) that inherits from > another class B (methods in file B). > The class A may overrides some methods of B which may become unused if B is > never instanciated and B methods not reused. > The

Re: Functions that should be static

2008-12-20 Thread Christian Costa
Francois Gouget a écrit : > On Thu, 18 Dec 2008, Christian Costa wrote: > [...] > >> For 1) Why not adding a keyword to mark these functions. Something like >> WINAPI which resolve to nothing but that can be tracked by your script. >> > > We could potentially go this way if I merge these c

Re: Functions that should be static

2008-12-19 Thread Francois Gouget
On Thu, 18 Dec 2008, Christian Costa wrote: [...] > For 1) Why not adding a keyword to mark these functions. Something like > WINAPI which resolve to nothing but that can be tracked by your script. We could potentially go this way if I merge these checks with winapi_check one day. But for now I

Re: Functions that should be static

2008-12-18 Thread Christian Costa
Hi Francois, For 1) Why not adding a keyword to mark these functions. Something like WINAPI which resolve to nothing but that can be tracked by your script. I would add another item for more object oriented stuff. Some default implentations can be written but not always used. This is sort of te