Re: Font problem + patch solution

2007-08-14 Thread Alexandre Julliard
"Abel Chiaro" <[EMAIL PROTECTED]> writes: > At least with those fonts (since I can't test every single font out > there), the patch fixes the issue. And it passes Dmitry's tests. The problem is that looking at differences in the traces is not a good test, since it can't be automated. What is real

Re: Font problem + patch solution

2007-08-14 Thread Abel Chiaro
Alexandre Julliard <[EMAIL PROTECTED]> wrote: > So does that test behave differently for you with your patch? Does it > show that things are fixed? Which font are you testing with? The patch adds a missing else to the codepage tests in WineEngEnumFonts(), making it handle DEFAULT_CHARSET rather

Re: Font problem + patch solution

2007-08-14 Thread Alexandre Julliard
"Abel Chiaro" <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: >> You should provide test cases that show that your patch is correct. > > I used Dmitry's tests [1] for this patch. > > [1] http://www.winehq.org/pipermail/wine-patches/2007-March/036706.html > > Shouldn't that be enough, I'll

Re: Font problem + patch solution

2007-08-14 Thread Abel Chiaro
Alexandre Julliard wrote: > [EMAIL PROTECTED] writes: > > > There is a patch proposed at the bug #7571 > > (http://bugs.winehq.org/show_bug.cgi?id=7571). > > It works very well and I did not experiment any regression. Maybe > > it is not the ideal patch and if it is not, maybe we c

Re: Font problem + patch solution

2007-08-14 Thread Alexandre Julliard
[EMAIL PROTECTED] writes: > There is a patch proposed at the bug #7571 > (http://bugs.winehq.org/show_bug.cgi?id=7571). > It works very well and I did not experiment any regression. Maybe > it is not the ideal patch and if it is not, maybe we can provide a fix for > that. Howeve

Font problem + patch solution

2007-08-14 Thread penna
Hi all, Since wine 0.9.31 there is a font problem (at least latin charset). There is a patch proposed at the bug #7571 (http://bugs.winehq.org/show_bug.cgi?id=7571). It works very well and I did not experiment any regression. Maybe it is not the ideal patch and if it is