Re: Fix for LoadStringW

2008-01-21 Thread Dmitry Timoshkov
"Christopher" <[EMAIL PROTECTED]> wrote: > @@ -363,10 +363,14 @@ INT WINAPI LoadStringW( HINSTANCE instance, UINT > resource_id, > WCHAR *p; > int string_num; > int i; > +int strlen; strlen is not the best variable name. > TRACE("instance = %p, id = %04x, buffer = %p, length

Re: Fix for LoadStringW

2008-01-19 Thread Stefan Leichter
Am Saturday 19 January 2008 07:32 schrieb Christopher: > Ferenc Wagner wrote: > > "Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > >> "Christopher" <[EMAIL PROTECTED]> wrote: > >>> Thanks for pointing that out! Am I suppose to attach a test case for > >>> all my patches to wine-patches? I had submi

Re: Fix for LoadStringW

2008-01-18 Thread Christopher
Ferenc Wagner wrote: > "Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > > >> "Christopher" <[EMAIL PROTECTED]> wrote: >> >> >>> Thanks for pointing that out! Am I suppose to attach a test case for all >>> my patches to wine-patches? I had submitted a testcase under the bug >>> report I fi

Re: Fix for LoadStringW

2008-01-17 Thread Ferenc Wagner
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "Christopher" <[EMAIL PROTECTED]> wrote: > >> Thanks for pointing that out! Am I suppose to attach a test case for all >> my patches to wine-patches? I had submitted a testcase under the bug >> report I filed, so I didn't attach it to the email. >

Re: Fix for LoadStringW

2008-01-17 Thread Dmitry Timoshkov
"Christopher" <[EMAIL PROTECTED]> wrote: > Thanks for pointing that out! Am I suppose to attach a test case for all > my patches to wine-patches? I had submitted a testcase under the bug > report I filed, so I didn't attach it to the email. You have to add the test to the exiting tests in dlls/

Re: Fix for LoadStringW

2008-01-17 Thread James Hawkins
On Jan 17, 2008 2:10 AM, Christopher <[EMAIL PROTECTED]> wrote: > > James Hawkins wrote: > > On Jan 17, 2008 1:31 AM, Christopher <[EMAIL PROTECTED]> wrote: > > > >> This patch fixes LoadStringW when 0 is passed for buflen. LoadStringW > >> should now behave as described on MSDN: > >> http://msdn2.

Re: Fix for LoadStringW

2008-01-17 Thread Christopher
James Hawkins wrote: > On Jan 17, 2008 1:31 AM, Christopher <[EMAIL PROTECTED]> wrote: > >> This patch fixes LoadStringW when 0 is passed for buflen. LoadStringW >> should now behave as described on MSDN: >> http://msdn2.microsoft.com/en-us/library/ms647486.aspx >> >> This patch also fixes bug #

Re: Fix for LoadStringW

2008-01-16 Thread James Hawkins
On Jan 17, 2008 1:31 AM, Christopher <[EMAIL PROTECTED]> wrote: > This patch fixes LoadStringW when 0 is passed for buflen. LoadStringW > should now behave as described on MSDN: > http://msdn2.microsoft.com/en-us/library/ms647486.aspx > > This patch also fixes bug #10932 > > Christopher Berner > >