Hi Philippe, a couple more thoughts:
+TCHAR* convert_multistringvalue( BOOL toRegistryFormat, TCHAR* value,
LONG *len )
This function shares very little code between the toRegistryFormat ==
FALSE and toRegistryFormat == TRUE versions. I think this would be
cleaner as two separate functions.
+
Thanks a lot for the comments guys!
Here's a revised patch.. no more C++ style comments, no more inline
variable declarations and no more useless casting!
I think it should work pretty well.
I'll keep you updated with anything else I try soon as promised!
Philippe? patch-multistringvalue-1.1.diff
Hedos wrote:
Hello folks!
I'm new to Wine development, and I've just completed my first patch. I
hope I could get some advices to make sure I'm heading in the right
direction.
Just a bit myself now to clear up a few things: I'm a first year
college student who realized this week-
On Mon, 24 Apr 2006 02:59:40 -0400, Hedos wrote:
> Just a bit myself now to clear up a few things: I'm a first year college
> student
Cool! Let us know how you get on. Wine can be a slightly intimidating
codebase at first but I found (back when I was about to enter my first
year and started on
Hedos wrote:
It is quite simple and definitly not concerning Wine's core code, but I
thought it'd be a good start.
Hi Philippe,
I had a quick look at your patch, and here are my comments:
+if( !(newString = (TCHAR*)HeapAlloc(GetProcessHeap(), 0,
lenbytes)) )
+return
Hello folks!
I'm new to Wine development, and I've just completed my first patch. I
hope I could get some advices to make sure I'm heading in the right
direction.
Just a bit myself now to clear up a few things: I'm a first year college
student who realized this week-end the Google Summer
