Re: First complete test run passing on a Windows platform

2009-02-01 Thread Florian Köberle
Hello Gé. I ran the test 30 times using the same way you did without any failure. I used a vm with 1 CPU assigned too. Installed is a Windows XP with SP2. If I start the test twice so that two tests are running parallel then I get test failures too, but: Do we really have the requirement that te

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Ge van Geldorp [mailto:g...@gse.nl] On Behalf Of 'Florian Köberle' Sorry, I messed up the headers. The previous message containing: > BTW, this causes failures also with my own fix applied (althoug only a > single failure instead of a bunch), so my own fix wasn't correct either. was sent

RE: First complete test run passing on a Windows platform

2009-01-30 Thread 'Florian Köberle'
> From: Ge van Geldorp [mailto:g...@gse.nl] > I've done some more experimenting and can get the problem to > reproduce more consistently (like 95% of the time instead of > 25%) by launching my shortcut twice (so I have two test runs > going at the same time). Then both of the runs will usually

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
Florian, > From: Florian Köberle [mailto:flor...@fkoeberle.de] > How many cores do your processor have? > I have a dual core which might make the difference. I ran inside a VM that had 1 CPU assigned, so single core. > How exactly do you execute the tests? > I executed "../../../tools/runtest -

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Florian Köberle
Hello Gé. >> I think the main problem is that the thread might run >> parallel with some other test code. >> >> That is why I would suggest to wait for the thread to finish >> at the end of the test. >> >> I made a patch and attached it to this email. I can't >> reproduce the failure on my syste

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
Hi Florian, > From: Florian Köberle [mailto:flor...@fkoeberle.de] > I think the main problem is that the thread might run > parallel with some other test code. > > That is why I would suggest to wait for the thread to finish > at the end of the test. > > I made a patch and attached it to this

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Florian Köberle
Ge van Geldorp wrote: >> From: Reece Dunn [mailto:mscl...@googlemail.com] >> >> Do you know why you need to do a SetForegroundWindow there to >> make the tests succeed? >> Why is the input being sent to a different window? >> Why does it vary from platform-to-platform and machine-to-machine? >>

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Paul Vriens
Reece Dunn wrote: 2009/1/30 Ge van Geldorp : From: Reece Dunn The Wine tests are now passing on a Windows XP machine (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.o

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Reece Dunn [mailto:mscl...@googlemail.com] > > Do you know why you need to do a SetForegroundWindow there to > make the tests succeed? > Why is the input being sent to a different window? > Why does it vary from platform-to-platform and machine-to-machine? It's a timing issue. It doesn't

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Reece Dunn
2009/1/30 Ge van Geldorp : >> From: Reece Dunn >> >> The Wine tests are now passing on a Windows XP machine >> > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group > _XP). > > Actually, that was not the first time. On 20 Jan an XP machine passed: > http://test.winehq.org/

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Reece Dunn > > The Wine tests are now passing on a Windows XP machine > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.org/data/e9d8c9f572998054b1f9c386ea81a3570

Re: First complete test run passing on a Windows platform

2009-01-29 Thread Paul Vriens
Reece Dunn wrote: > Hi, > > The Wine tests are now passing on a Windows XP machine > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group_XP). > Two of the other four only have 2 or 3 failures. > > The 2003 group has 3 machines with 1 failure each (urlmon:protocol on > one

Re: First complete test run passing on a Windows platform

2009-01-29 Thread Zachary Goldberg
2009/1/29 Dan Kegel : > Wow, that's awesome! A day seven years in the making... > 2009: the test suite passes for somebody besides Alexandre on Wine: > http://www.winehq.org/wwn/355#Test%20Suite%20Passes! We'll have a new link to WWN 356 for Test Suite Passes v2 : Windows Style :) Congrats to t

re: First complete test run passing on a Windows platform

2009-01-29 Thread Dan Kegel
Wow, that's awesome! A day seven years in the making... 2002: the C test suite is started: http://source.winehq.org/git/wine.git/?a=commit;h=caa03388b64f444f9b4ef664ec5039d5bf72 2003: winetest committed: http://www.winehq.org/wwn/199#Winetest%20Integrated%20&%20Future%20Steps 2004: server

First complete test run passing on a Windows platform

2009-01-29 Thread Reece Dunn
Hi, The Wine tests are now passing on a Windows XP machine (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group_XP). Two of the other four only have 2 or 3 failures. The 2003 group has 3 machines with 1 failure each (urlmon:protocol on one, user32:menu on the others). Con