Re: Feedback requested on an OpenAL audio driver patch -- #2

2006-06-08 Thread Nick Burns
Got ya will remove that when I send to the wine patch list From: "James Hawkins" <[EMAIL PROTECTED]> Subject: Re: Feedback requested on an OpenAL audio driver patch -- #2 Date: Thu, 8 Jun 2006 10:03:19 -0700 On 6/8/06, Nick Burns <[EMAIL PROTECTED]> wrote: Ok I fixed

Re: Feedback requested on an OpenAL audio driver patch -- #2

2006-06-08 Thread James Hawkins
On 6/8/06, Nick Burns <[EMAIL PROTECTED]> wrote: Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff You're not supposed t

Feedback requested on an OpenAL audio driver patch -- #2

2006-06-08 Thread Nick Burns
Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff 2. configure.ac now checks for AL/al.h (which is where OpenAL should be)

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Marcus Meissner
On Wed, Jun 07, 2006 at 09:36:35PM -0700, Nick Burns wrote: > >From: Leon Freitag <[EMAIL PROTECTED]> > >Date: Wed, 7 Jun 2006 12:09:36 +0200 > > > >P.S. Isn't it better to use pkg-config to check where the libs are located > >anyway? > >Leon > > Is there an example of this? Yes, see the libxml2

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Leon Freitag <[EMAIL PROTECTED]> Date: Wed, 7 Jun 2006 12:07:32 +0200 > AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ >AudioUnit/AudioUnit.h \ >CoreAudio/CoreAudio.h \ >IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Sus

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Leon Freitag <[EMAIL PROTECTED]> Date: Wed, 7 Jun 2006 12:09:36 +0200 P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon Is there an example of this? - Nick

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Leon Freitag <[EMAIL PROTECTED]> Date: Wed, 7 Jun 2006 15:54:49 +0200 My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal versi

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Nick Burns
From: Robert Reif <[EMAIL PROTECTED]> Date: Wed, 07 Jun 2006 20:55:58 -0400 Nick Burns wrote: It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) How do t

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Robert Reif
Nick Burns wrote: It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) How do the winmm and dsound regression tests work when run in the interactive mode?

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Leon Freitag
P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon pgpbKZ8HlkpCr.pgp Description: PGP signature

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Leon Freitag
My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal version is 1.0.20051129) 2) It'd be better to convert ALC errors from FIXMEs to ERRs.

Re: Feedback requested on an OpenAL audio driver patch

2006-06-07 Thread Leon Freitag
> AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ > AudioUnit/AudioUnit.h \ > CoreAudio/CoreAudio.h \ > IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Suse 10.1) puts openal headers to AL/ instead of al/ and so configu