Re: Feedback request on wininet patch

2006-03-06 Thread Robert Shearman
Victor Pelt wrote: @@ -2447,7 +2485,18 @@ BOOL WINAPI InternetSetOptionW(HINTERNET TRACE("Option INTERNET_OPTION_DISABLE_PASSPORT_AUTH: harmless stub, since not enabled\n"); break; case INTERNET_OPTION_RECEIVE_TIMEOUT: -FIXME("Option INTERNET_OPTION_RECEIVE_TIMEOUT:

Re: Feedback request on wininet patch

2006-03-06 Thread Vijay Kiran Kamuju
Hi Victor, If you are interested in implementing more features. You can have a look at my wininet pacthes, almost all of them have been rejected. I hope you might improve those or get new ideas from those. As i am going to pick some other well documented portion in windows api. Leaving the wininet

Re: Feedback request on wininet patch

2006-03-05 Thread Mike McCormack
Victor Pelt wrote: -FIXME("Option INTERNET_OPTION_RECEIVE_TIMEOUT: STUB\n"); + { It would be nice if you could use indentation consistent with the rest of the file, and avoid tabs. + unsigned long conns=*(unsigned long*)lpBuffer; What's 'conns' for? + /* have

Feedback request on wininet patch

2006-03-05 Thread Victor Pelt
Hey I implemented one of the missing options in InternetSetOption. Any feedback about the way i implemented it would be appreciated. If it is alright i will implement the other missing options too regards Victor Pelt diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index f52103d..d1