Re: FDI: Constify some variables

2007-03-16 Thread Andrew Talbot
James Hawkins wrote: > That's not how it works. PFNOPEN, et al., has a specific definition > that is similar to, but not the same as, the corresponding low-level > file IO function. If you make a change to a public header, you need > to check the same header in the SDK and make sure that the cha

Re: FDI: Constify some variables

2007-03-15 Thread James Hawkins
On 3/15/07, Andrew Talbot <[EMAIL PROTECTED]> wrote: James Hawkins wrote: > Are you checking with the SDK to make sure these changes are legit? > This isn't how the Windows SDK fdi.h has these defined. > I ascertained that the function-pointer parameters of FDICreate() should have the same sign

Re: FDI: Constify some variables

2007-03-15 Thread Andrew Talbot
James Hawkins wrote: > Are you checking with the SDK to make sure these changes are legit? > This isn't how the Windows SDK fdi.h has these defined. > I ascertained that the function-pointer parameters of FDICreate() should have the same signatures as the corresponding low-level file functions (

Re: FDI: Constify some variables

2007-03-15 Thread James Hawkins
On 3/15/07, Andrew Talbot <[EMAIL PROTECTED]> wrote: Changelog: FDI: Constify some variables. diff -urN a/dlls/cabinet/cabinet_main.c b/dlls/cabinet/cabinet_main.c --- a/dlls/cabinet/cabinet_main.c 2007-03-15 17:31:18.0 + +++ b/dlls/cabinet/cabinet_main.c 2007