Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow (resend)

2013-05-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25614 Your paranoid android

Re: [PATCH 1/2] Added test to show EnableWindow cause wrong ReleaseCapture (try 3)

2013-05-14 Thread Henri Verbeet
On 9 May 2013 19:10, Guo Jian wrote: > Hello everyone, > This is my first patch to wine, which has been submitting since the last > day. Please help that what is the safe way sending patches that makes sure > the patch is not corrupt by my mail client? Is it the most correct way to > attach a

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow

2013-05-09 Thread Guo Jian
> Did you forget to remove the todo_wine introduced in [patch 1/2]? I forgot it. I'll have more check and resend once latter. And I get a little more to understand what todo_wine means this time. Thank you. -- Regards, Guo Jian

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow

2013-05-09 Thread Qian Hong
Hello Guo Jian, On Fri, May 10, 2013 at 1:36 AM, Guo Jian wrote: > A window should not lose mouse capture even when it's parent window is > disabled. Did you forget to remove the todo_wine introduced in [patch 1/2]? Thanks for your work on it. -- Regards, Qian Hong

[PATCH 1/2] Added test to show EnableWindow cause wrong ReleaseCapture (try 3)

2013-05-09 Thread Guo Jian
ntToScreen(hwnd, &pnt); +SetCursorPos(pnt.x, pnt.y); +mouse_event(MOUSEEVENTF_LEFTDOWN, 0, 0, 0, 0); + +/* set capture to child */ +ReleaseCapture(); +SetCapture(child); +cap = GetCapture(); + ok(cap == child, "SetCapture failed.\n"); +/* disable

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture

2013-05-08 Thread Qian Hong
Hi orzhvs, Thanks for your work on it, however, it seems gmail's line wrap 'feature' (hmm, isn't that a bug...) breaks your patch, you could try fight with that feature or send your patch as attachment instead.

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture

2013-05-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25486 Your paranoid android

Re: EnableWindow

2004-05-28 Thread Alexandre Julliard
Ulrich Czekalla <[EMAIL PROTECTED]> writes: > ChangeLog: > Ulrich Czekalla <[EMAIL PROTECTED]> > EnableWindow should not remove the focus of child windows Thanks for providing a test, but could you please merge it with the existing win.c and/or msg.c tests?