Re: Dynamic memory management in CryptAcquireContext

2004-08-02 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > If the CSP's CPAcquireContext function fails, which is quite common (e.g. > because the user specified key container does not exist), the "temp" variable > is still free'd twice. Yes, the free needs to be moved inside the if, sorry about that. > I'm a

Dynamic memory management in CryptAcquireContext

2004-08-02 Thread Michael Jung
Alexandre, I've noticed that you applied a modified version of my patch, which tries to fix a potential double free of the "temp" variable in dlls/advapi32/crypt.c's CryptAcquireContextA function. However, I think that the modified version does not fix the problem. Here is a code snippet from t