Re: DDraw: Better flag handling in SetCooperativeLevel

2005-10-04 Thread Stefan Dösinger
Hello, > > Alexandre, any reason why this patch (plus the other about the reference > > counting) were not applied ? If you were waiting for some DDraw 'guru' to > > give his blessing, they both look OK to me :-) > I think the reference counting one is suspect, there should be some > object that ho

Re: DDraw: Better flag handling in SetCooperativeLevel

2005-09-27 Thread Stefan Dösinger
> I think the reference counting one is suspect, there should be some > object that holds the reference, we shouldn't just increment it for no > reason. > > For the other one, the tests fail here: Thanks for the info, I'll try to fix the patches as soon as possible. Unfortunatly my notebook is b

Re: DDraw: Better flag handling in SetCooperativeLevel

2005-09-27 Thread Alexandre Julliard
Lionel Ulmer <[EMAIL PROTECTED]> writes: > On Thu, Sep 08, 2005 at 12:03:52PM +0200, Stefan Dösinger wrote: >> Changelog: >> *Add handling for DDSCL_SETFOCUSWINDOW in SetCooperativeLevel >> *Print a fixme for DDSCL_CREATEDEVICEWINDOW and DDSCL_SETDEVICEWINDOW. > > Alexandre, any reason why this p

Re: DDraw: Better flag handling in SetCooperativeLevel

2005-09-25 Thread Lionel Ulmer
On Thu, Sep 08, 2005 at 12:03:52PM +0200, Stefan Dösinger wrote: > Changelog: > *Add handling for DDSCL_SETFOCUSWINDOW in SetCooperativeLevel > *Print a fixme for DDSCL_CREATEDEVICEWINDOW and DDSCL_SETDEVICEWINDOW. Alexandre, any reason why this patch (plus the other about the reference counting)

Re: DDraw: Better flag handling in SetCooperativeLevel

2005-09-11 Thread Stefan Dösinger
Hello, This patch was still not applied. Is anything wrong with it? Does anyone have improvement suggestions? http://www.winehq.org/pipermail/wine-patches/2005-September/020551.html Thanks, Stefan Dösinger

Re: DDraw: Better flag handling in SetCooperativeLevel

2005-08-29 Thread Stefan Dösinger
Am Donnerstag, 25. August 2005 18:45 schrieb Stefan Dösinger: > Hello, > This patch adds better handling for the flags in > Main_DirectDraw_SetCooperativeLevel. The function reacts to > DDSCL_SETFOCUSWINDOW, DDSCL_CREATEDEVICEWINDOW and DDSCL_SETDEVICEWINDOW. > It doesn't really handle them, but it