De : Matteo Bruni
À : Nozomi Kodama
Cc : Wine Devel
Envoyé le : Jeudi 1 août 2013 9h46
Objet : Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon
2013/8/1 Nozomi Kodama :
>
+ vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) *
siz
2013/8/1 Nozomi Kodama :
>
+vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) *
sizeof(D3DXVECTOR3));
+if (!vertices)
+{
+TRACE("Not memory enough for vertex buffer\n");
+polygon->lpVtbl->Release(polygon);
+return E_OUTOFMEMORY;
+}
+
+hr = polygo
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=18615
Your paranoid android
On Sun, Apr 1, 2012 at 10:43 PM, David Adam wrote:
> +*mesh = polygon;
> +
> +if (adjacency)
> +{
> +hr = D3DXCreateBuffer(3 * sides * sizeof(DWORD), &adjacency_tmp);
> +if (FAILED(hr)) return hr;
You should release the polygon mesh. Also, you probably shouldn't
touch
Hello
are there still problems with the patches:
http://source.winehq.org/patches/data/82408 and
http://source.winehq.org/patches/data/82409 ?
Thanks in advance
A+
David
Am 10.11.2011 10:59, schrieb David Adam:
Hello,
I tried to fix the remaining issues pointed by Matteo and Rico.
I kept the style of Misha Koshelev who already implemented many shapes in
the mesh.c file.
Any more suggestions?
David
Hi David,
I still have some suggestions. Please review all
Am 09.11.2011 14:42, schrieb Matteo Bruni:
2011/11/9 David Adam:
Better, but there are still issues:
+if( polygon ) polygon->lpVtbl->Release(polygon);
+if( ppBuffer ) ID3DXBuffer_Release(ppBuffer);
You aren't setting those pointers to NULL (and your test shows that
D3DXCr
2011/11/9 David Adam :
>
Better, but there are still issues:
+if( polygon ) polygon->lpVtbl->Release(polygon);
+if( ppBuffer ) ID3DXBuffer_Release(ppBuffer);
You aren't setting those pointers to NULL (and your test shows that
D3DXCreatePolygon doesn't touch them when
: David Adam
> Date: 2011/10/30
> Subject: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon
> To: wine-patches
>
>
> Fix a possible crash when calling D3DXCreateMeshFVF.
>
> A+
>
> David
>
>
>
>
>
Hello David,
I see Rico preceded me (his
helps
Rico
Am 07.11.2011 20:58, schrieb David Adam:
Hello,
any problem with this patch
http://source.winehq.org/patches/data/80433
and this one
http://source.winehq.org/patches/data/80434
Thanks in advance
David
-- Forwarded message --
From: David Adam
Date: 2011/10/30
Subjec
D3DXCreatePolygon
To: wine-patches
Fix a possible crash when calling D3DXCreateMeshFVF.
A+
David
From 5ea4a204acd81c560ab20fb7b00774b716340eb3 Mon Sep 17 00:00:00 2001
From: David Adam
Date: Mon, 31 Oct 2011 01:29:33 +0100
Subject: Implement D3DXCreatePolygon
---
dlls/d3dx9_36/d3dx9_36.spec |2
On Tue, Oct 25, 2011 at 08:10, paulo lesgaz wrote:
> Hello,
> any problem with my D3DXCreatePolygon patch?
> Thanks in advance.
> David
Don't see it on wine-patches, or http://source.winehq.org/patches/
Did you subscribe to wine-patches?
Also, avoid HTML mail on wine mailing li
Any problem with my D3DXCreatePolygon patch?
Thanks in advance.
David
Hello,
any problem with my D3DXCreatePolygon patch?
Thanks in advance.
David
14 matches
Mail list logo
