Re: Correct ConvertSidToStringSidW with test

2004-09-14 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > ChangeLog: fix ConvertSidToStringSidW for all expected > values, and add tests The tests fail for me on XP SP1 (I added some debug output): security.c:85: Test failed: failed to parse sid string S-1-860116326 err 1337 security.c:85: Test failed: failed to

Re: Correct ConvertSidToStringSidW with test

2004-09-13 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > @@ -2230,13 +2232,23 @@ > > sz = 14 + pisid->SubAuthorityCount * 11; > str = LocalAlloc( 0, sz*sizeof(WCHAR) ); > -sprintfW( str, fmt, pisid->Revision, > - pisid->IdentifierAuthority.Value[2], > - pisid->IdentifierAuthority.Va

Re: Correct ConvertSidToStringSidW with test

2004-09-11 Thread Dimitrie O. Paun
On Sat, Sep 11, 2004 at 08:37:09AM -0700, Juan Lang wrote: > ConvertSidToStringSidW was incorrect for low-value > authorities; it put spaces in the resulting string. > This corrects that, and includes a test case for it. Content-Description: advapi32.diff Uniffied diff, please :) -- Dimi.