Re: Check Server Version From Client Dlls

2004-07-22 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > DLL separation is not going to help when a function in user32 calls > the server and fails due to mismatched server interfaces. Yes it will, because part of that task is also to ensure that the server protocol is backwards compatible. This isn't fully

Re: Check Server Version From Client Dlls

2004-07-22 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: DLL separation is not going to help when a function in user32 calls the server and fails due to mismatched server interfaces. Yes it will, because part of that task is also to ensure that the server protocol is backwards

Re: Check Server Version From Client Dlls

2004-07-22 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: if (ver != SERVER_PROTOCOL_VERSION) MESSAGE( "Error: server version mismatch.\n" "Your %s binary was not upgraded correctly\n" "or the wrong wineserver is still running.\n", dl

Re: Check Server Version From Client Dlls

2004-07-22 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: >> if (ver != SERVER_PROTOCOL_VERSION) >> MESSAGE( "Error: server version mismatch.\n" >> "Your %s binary was not upgraded correctly\n" >> "or the wrong wineserver is still running.\n", dll_na

Re: Check Server Version From Client Dlls

2004-07-22 Thread Robert Shearman
Andreas Mohr wrote: Hi, On Thu, Jul 22, 2004 at 02:59:47PM +0100, Robert Shearman wrote: Changelog: Check server version from x11drv, kernel32 and user32 to prevent mismatches of installed dlls. Slight overkill, I'd say. Why not do: if (!wine_server_check_version( "x11drv", SERVER_PROTOCOL

Re: Check Server Version From Client Dlls

2004-07-22 Thread Andreas Mohr
Hi, On Thu, Jul 22, 2004 at 02:59:47PM +0100, Robert Shearman wrote: > > Changelog: > Check server version from x11drv, kernel32 and user32 to prevent > mismatches of installed dlls. Slight overkill, I'd say. Why not do: if (!wine_server_check_version( "x11drv", SERVER_PROTOCOL_VERSION )) ...