It does match the style of the way that HeapAlloc is used elsewhere in the
file, though not malloc admittedly. I wasn't sure which convention had
precedent.
I'm afraid that I don't understand how my changelog doesn't match the
patch. I'm new here, can you help me out? There's obviously somethin
> In addition to what James said please split the patch up; one patch per
> module. A dll or program is a "module".
Sorry, I'm inundated with noobie errors here I think.
> Also while you are at it please remove the superfluous casts in the lines
> you are changing. HeapAlloc (malloc too) returns
2008/10/30 James Hawkins <[EMAIL PROTECTED]>
>
> On Wed, Oct 29, 2008 at 8:02 PM, Pete Myers
> <[EMAIL PROTECTED]> wrote:
> > It does match the style of the way that HeapAlloc is used elsewhere in the
> > file, though not malloc admittedly. I wasn't sure which convention had
> > precedent.
> >
>
>
Pete Myers wrote:
>> In addition to what James said please split the patch up; one patch per
>> module. A dll or program is a "module".
>
> Sorry, I'm inundated with noobie errors here I think.
No problem. Janitorial tasks are really good to accustom new people to
the patch submission process.
>
Hello Pete,
James Hawkins wrote:
> On Wed, Oct 29, 2008 at 8:02 PM, Pete Myers
> <[EMAIL PROTECTED]> wrote:
>> It does match the style of the way that HeapAlloc is used elsewhere in the
>> file, though not malloc admittedly. I wasn't sure which convention had
>> precedent.
>>
>
> Please bottom-p
On Wed, Oct 29, 2008 at 8:02 PM, Pete Myers
<[EMAIL PROTECTED]> wrote:
> It does match the style of the way that HeapAlloc is used elsewhere in the
> file, though not malloc admittedly. I wasn't sure which convention had
> precedent.
>
Please bottom-post when replying to a post on the wine lists.
On Wed, Oct 29, 2008 at 7:39 PM, Pete Myers
<[EMAIL PROTECTED]> wrote:
> In line with http://wiki.winehq.org/ReplaceMalloc this is a small patch that
> changes all malloc calls to HeapAlloc in the following files:
> ./dlls/iphlpapi/tests/iphlpapi.c
> ./dlls/wnaspi32/winaspi16.c
>
> Changelog:
> * m
