Re: Changed files to use interlocked functions

2005-01-04 Thread Dimitrie O. Paun
On Tue, Jan 04, 2005 at 02:59:45PM +0100, Paul Vriens wrote: > Are there AddRef's or Releases that don't need the modification? Or is it > OK to modify all of them? I think it's OK to modify them all. > What's the best way to generate mail/patches for this bulk. One email for > each file/dll? Inl

Re: Changed files to use interlocked functions

2005-01-04 Thread Rob Shearman
Paul Vriens wrote: Hi Mike, Are there AddRef's or Releases that don't need the modification? Or is it OK to modify all of them? Theoretically, COM classes that are registered with "ThreadingModel"="Apartment" do not need to use the atomic increment/decrement functions as they shouldn't be a

Re: Changed files to use interlocked functions

2005-01-04 Thread Mike McCormack
Paul Vriens wrote: Are there AddRef's or Releases that don't need the modification? Or is it OK to modify all of them? I think it should be safe to do all of them. InterlockedIncrement is inline, so it shouldn't have any performance penalty. It may not strictly be necessary for objects in single

Re: Changed files to use interlocked functions

2005-01-04 Thread Paul Vriens
Hi Mike, > > > Paul Vriens wrote: > >> the Janitorial page shows that the "Use Interlocked functions in AddRef >> and Release methods" project is finished. >> >> There are however several files (at least 135) that still use the >> non-interlocked method. Especially ddraw, d3*, dm*, avifil32 and som

Re: Changed files to use interlocked functions

2005-01-04 Thread Mike McCormack
Paul Vriens wrote: the Janitorial page shows that the "Use Interlocked functions in AddRef and Release methods" project is finished. There are however several files (at least 135) that still use the non-interlocked method. Especially ddraw, d3*, dm*, avifil32 and some ole/oleaut32. Do they still n

Changed files to use interlocked functions

2005-01-04 Thread Paul Vriens
Hi, the Janitorial page shows that the "Use Interlocked functions in AddRef and Release methods" project is finished. There are however several files (at least 135) that still use the non-interlocked method. Especially ddraw, d3*, dm*, avifil32 and some ole/oleaut32. Do they still need to be cha