Andrew Talbot <[EMAIL PROTECTED]> writes:
> What is wrong with this patch, please?
You broke the function completely. Look closer...
--
Alexandre Julliard
[EMAIL PROTECTED]
Andrew Talbot <[EMAIL PROTECTED]> writes:
> What is wrong with this patch, please?
The proper fix is the make the categories field non const.
--
Alexandre Julliard
[EMAIL PROTECTED]
--- Paul Vriens <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Fix a warning and remove the now not needed cast.
>
> Changelog
> Cast-qual warning fix
>
> Cheers,
>
> Paul.
>
>
> > diff --git a/dlls/urlmon/umon.c
b/dlls/urlmon/umon.c
> index
8eda98dad9a89a8e71c6ea37bd168
>>>
>>>
>>> Author: Paul Vriens <[EMAIL PROTECTED]>
>>> Date: Fri Jan 12 14:26:05 2007 +0100
>>>
>>> mshtml/tests: Cast-qual warning fix.
>>
>> This breaks compilation with older gcc version
14:26:05 2007 +0100
mshtml/tests: Cast-qual warning fix.
This breaks compilation with older gcc versions. At least with gcc-3.1.1
used by Smatch.
dlls/mshtml/tests/htmldoc.c: In function `test_Load':
dlls/mshtml/tests/htmldoc.c:1806: invalid initializer
make[2]: *** [htmldoc.o] Error 1
Hi
Fri Jan 12 14:26:05 2007 +0100
>
> mshtml/tests: Cast-qual warning fix.
This breaks compilation with older gcc versions. At least with gcc-3.1.1
used by Smatch.
dlls/mshtml/tests/htmldoc.c: In function `test_Load':
dlls/mshtml/tests/htmldoc.c:1806: invalid initializer
make[2]: ***
> Hi Andy,
>
> the failing allocation was for lpNewFormat->Name. The freeing was for
> lpNewFormat on line 516 (original).
>
> Cheers,
>
> Paul.
Whoops! You're right. Thank you for pointing it out; I shall post a "please
ignore" to wine-patches.
-- Andy.
On Sat, 2006-11-25 at 14:01 +, Andrew Talbot wrote:
> Paul Vriens wrote:
>
> > Just out of curiosity. Why is the HeapFree superfluous? It is allocated
> > a few lines above and not free-ed in this fail condition.
> >
> > Cheers,
> >
> > Paul.
>
> Hi Paul,
>
> The fail condition is that no
Paul Vriens wrote:
> Just out of curiosity. Why is the HeapFree superfluous? It is allocated
> a few lines above and not free-ed in this fail condition.
>
> Cheers,
>
> Paul.
Hi Paul,
The fail condition is that no memory was available, therefore, what is there
to free?
-- Andy.
On Sat, 2006-11-25 at 12:41 +, Andrew Talbot wrote:
> Changelog:
> winex11.drv: Cast-qual warning fix + remove superfluous HeapFree().
>
> diff -urN a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c
> --- a/dlls/winex11.drv/clipboard.c2006-10-09 20:06:04.
I really wonder why we do have our own memcpy() here and why there is a
strange /* FIXME: using memcpy can cause strange crashes so use this fake one */
comment above it.
may be optimisations in memcpy using dword* reads and writes may cause
issues in buffers mapped by the sound driver (dep
On Thu, Nov 23, 2006 at 08:29:00PM +, Andrew Talbot wrote:
> Changelog:
> winmm/wineoss: Cast-qual warning fix.
>
> diff -urN a/dlls/winmm/wineoss/dscapture.c b/dlls/winmm/wineoss/dscapture.c
> --- a/dlls/winmm/wineoss/dscapture.c 2006-11-13 17:34:40.0 +
>
Andrew Talbot <[EMAIL PROTECTED]> writes:
> In our case, MSIITERHANDLE is declared as a pointer to void, so
>
> const MSIITERHANDLE *handle;
>
> is equivalent to
>
> void *const *handle;
>
> whereas
>
>MSICITERHANDLE *handle;
>
> is equivalent to
>
>const void **handle;
>
> which,
Francois Gouget wrote:
> Actually they are in recent PSDKs (for instance the Windows 2003 SP2
> PSDK).
>
> So this patch should not be applied.
>
Acknowledged with thanks to Dmitry and yourself.
-- Andy.
On Sat, 4 Nov 2006, Andrew Talbot wrote:
> The last formal argument of MCIWndCreate() is not const-qualified in the SDK.
Actually they are in recent PSDKs (for instance the Windows 2003 SP2
PSDK).
So this patch should not be applied.
--
Francois Gouget <[EMAIL PROTECTED]> http://
Dmitry Timoshkov wrote:
> "Andrew Talbot" <[EMAIL PROTECTED]> wrote:
>
>> The last formal argument of MCIWndCreate() is not const-qualified in the
>> SDK.
>
> It is in my version of the PSDK headers, but it is not in the PSDK docs.
>
Not having access to any version of the SDK, my only source
Dmitry Timoshkov wrote:
> "Andrew Talbot" <[EMAIL PROTECTED]> wrote:
>
>> -typedef void *MSIITERHANDLE;
>> +typedef void*MSIITERHANDLE;
>> +typedef const void *MSICITERHANDLE;
>
> Personally I don't like MSICITERHANDLE typedef at all. It' not obvious
> that 'C' in the name marks constne
"Andrew Talbot" <[EMAIL PROTECTED]> wrote:
The last formal argument of MCIWndCreate() is not const-qualified in the SDK.
It is in my version of the PSDK headers, but it is not in the PSDK docs.
--
Dmitry.
"Andrew Talbot" <[EMAIL PROTECTED]> wrote:
-typedef void *MSIITERHANDLE;
+typedef void*MSIITERHANDLE;
+typedef const void *MSICITERHANDLE;
Personally I don't like MSICITERHANDLE typedef at all. It' not obvious
that 'C' in the name marks constness of the object. Using 'const' explicitl
Andrew Talbot <[EMAIL PROTECTED]> writes:
> So am I right to infer that, in such cases, you would rather that I leave
> the disqualifying casts in place?
For the moment, yes. Let's look at this again once all the places that
can be fixed properly are done.
--
Alexandre Julliard
[EMAIL PROTECTED
Alexandre Julliard wrote:
> I don't think we want to duplicate strings just because of the
> warning. If the string really needs to be writable sure, but if it's
> just because of MS broken prototypes it's not worth the extra cost.
>
So am I right to infer that, in such cases, you would rather t
Andrew Talbot <[EMAIL PROTECTED]> writes:
> --- a/dlls/advpack/reg.c 2006-06-14 12:55:31.0 +0100
> +++ b/dlls/advpack/reg.c 2006-08-28 17:00:18.0 +0100
> @@ -255,11 +255,14 @@
> /* FIXME: read AdvOptions val for dwFlags */
> ZeroMemory(&cabinfo, sizeof(CABINFOW)
22 matches
Mail list logo
