Re: BuildCommDCBAndTimeouts patch

2003-09-10 Thread Jakob Eriksson
Could you also make test.c into a regression test for inclusion into Wine? That is almost more important than the actual patch to Wine - if we have the conformance test, it ensures changes to Wine in the future does not destroy functionality. regards, Jakob

Re: BuildCommDCBAndTimeouts patch

2003-09-10 Thread Francois Gouget
On Tue, 9 Sep 2003, Kevin Groeneveld wrote: [..]. > One question I have is how should the differences in Windows versions be > handled? This question applies to both the wine implementation and the > tests. > > One example is that BuildCommDCB in Windows 95 sets the DCBlength member > of DCB but W

Re: BuildCommDCBAndTimeouts patch

2003-09-09 Thread Dimitrie O. Paun
On September 9, 2003 08:46 pm, Kevin Groeneveld wrote: > One question I have is how should the differences in Windows versions be > handled? This question applies to both the wine implementation and the > tests. > > One example is that BuildCommDCB in Windows 95 sets the DCBlength member > of DCB

Re: BuildCommDCBAndTimeouts patch

2003-09-09 Thread Kevin Groeneveld
Jakob Eriksson wrote: Could you also make test.c into a regression test for inclusion into Wine? That is almost more important than the actual patch to Wine - if we have the conformance test, it ensures changes to Wine in the future does not destroy functionality. I agree that this would be a good

Re: BuildCommDCBAndTimeouts patch

2003-09-08 Thread Dimitrie O. Paun
On September 8, 2003 09:21 pm, Kevin Groeneveld wrote: > To try and verify the correct operation of BuildCommDCBAndTimeouts I > wrote a small Windows program. This is a great idea, but you should submit this as a conformance test: http://www.winehq.org/site/docs/wine-devel/testing -- Dim