Re: Bug in dlls/comctl32/comctl32undoc.c

2005-07-02 Thread Felix Nawothnig
First of all: I sent a new DPA testsuite to wine-patches some hours ago (http://tinyurl.com/ddlp4) which tests DPA_InsertPtr() with both (nItems < idx < 0x7fff) and (0x7fff < idx). Our behaviour does not match Windows in both cases (besides several other differences). The tests are marked as t

Re: Bug in dlls/comctl32/comctl32undoc.c

2005-07-02 Thread Sascha Cunz
Hi, > > In lines 1944 and 1977 of dlls/comctl32/comctl32undoc.c the value > > "0x7FFF" is used to check for the boundary of a 32 bit integer. However, > > there should be used MAX_INT instead. > I somehow doubt that this function will ever encounter an INT greater > than MAX_INT... :) you're of

Re: Bug in dlls/comctl32/comctl32undoc.c

2005-07-01 Thread Felix Nawothnig
Sascha Cunz wrote: In lines 1944 and 1977 of dlls/comctl32/comctl32undoc.c the value "0x7FFF" is used to check for the boundary of a 32 bit integer. However, there should be used MAX_INT instead. I somehow doubt that this function will ever encounter an INT greater than MAX_INT... :) Anyway

Bug in dlls/comctl32/comctl32undoc.c

2005-06-30 Thread Sascha Cunz
Hi, playing around a bit with wine, i found a thing that is obviously a bug. In lines 1944 and 1977 of dlls/comctl32/comctl32undoc.c the value "0x7FFF" is used to check for the boundary of a 32 bit integer. However, there should be used MAX_INT instead. By the way: Looking at current MSDN, DPA