Re: Bug 50

2007-02-13 Thread Pedro Araujo Chaves Jr.
Hi all, I'm writing just to ask why my patch and test case for Bug 50 (the text justification issue) weren't committed yet, so that I can take the proper measures in order that they can be. Regards, Pedro.

Re: [GDI32] Fix for GetTextExtentExPointW() and ExtTextOutW() - Fixes Bug 50

2007-02-08 Thread John Smith
Hey Pedro, Was there supposed to be an attachment on your last message? I didn't see one. Regards, John Klehm On 2/8/07, Pedro Araujo Chaves Jr. <[EMAIL PROTECTED]> wrote: Attached is my proposed patch for Bug #50; the test case was attached in my previous message. -- Patch descrip

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-30 Thread Pedro Araujo Chaves Jr.
On 1/30/07, Dmitry Timoshkov wrote: Then probably DrawText(DT_CALCRECT) could better suit your needs. Almost on the bull's-eye! Actually, DrawText() returns the *height* of the string... how lucky I am, huh? But a "See Also" link in the MSDN page for DrawText() [1] pointed me to TabbedTextOu

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-29 Thread Dmitry Timoshkov
"Pedro Araujo Chaves Jr." <[EMAIL PROTECTED]> wrote: Here's the picture: when an application calls TextOut() for printing text, the usual (at least in my case) call sequence in Wine is TextOut() TextOutA() ExtTextOutA() ExtTextOutW() (the one I patched) GetTextExtentPointW() GetTextExtentPoint3

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-29 Thread Pedro Araujo Chaves Jr.
On 2007-01-29, Duane Clark wrote: GetTextExtentPoint32 For some examples in Wine, look at almost any control in comctl32. I was afraid somebody would answer that... Thanks for the quick reply, but that isn't exactly what I need. Here's the picture: when an application calls TextOut() for prin

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-29 Thread Duane Clark
Pedro Araujo Chaves Jr. wrote: I've just finished writing a test case for Bug 50, but I'm missing *a single thing* that prevents it from working under Windows: I still don't know how to get the width of the text output by ExtTextOutW(). GetTextExtentPoint32 For some examples i

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-29 Thread Pedro Araujo Chaves Jr.
I've just finished writing a test case for Bug 50, but I'm missing *a single thing* that prevents it from working under Windows: I still don't know how to get the width of the text output by ExtTextOutW(). MSDN isn't helping much, and I haven't found the optimal Googl

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-12 Thread Pedro Araujo Chaves Jr.
Update... I thought I had managed to get Keith's idea and make up a patch, but, to great grief -- and not so great a surprise --, I have just discovered that my patch for bug 50 is not as effective on Lotus Notes 6.5.3 as it was in Notes R5 and the Petzold justify1 example. Well, I'

Re: Test case for Bug 50 [Was: Bug 50]

2007-01-10 Thread Pedro Araujo Chaves Jr.
I think I've managed to patch [1] bug 50 [2], but I'm having a little trouble coming up with a proper test case... I'm already at it, studying and investigating, but could someone test that, too? [1] http://bugs.winehq.org/attachment.cgi?id=4543&action=view [2] htt

Re: Bug 50

2006-12-27 Thread Keith Dunwoody
Hi Pedro, Suppose the user asks for (on average) 5.5 pixels per space. At the moment wine is using 5 pixels per space, and then tacking on all the remaining .5 pixels at the end of the line. The correct answer would be to use 5 pixels in half the spaces, and 6 in the other half. This is essenti

Re: Bug 50

2006-12-27 Thread Pedro Araújo Chaves Jr.
Followup: you can download Lotus trial versions here: http://www.ibm.com/developerworks/lotus/downloads/ Hope this helps. Regards, Pedro.

Re: Bug 50

2006-12-27 Thread Pedro Araújo Chaves Jr.
I've been trying to get the lpDx array to be properly calculated, but unfortunately to no avail. I did find, though, that GetTextExtentExPointW is never called with a maxExt value other than zero, and thus nfit is not calculated. Regarding that, would any of you know where I should look for the p

Re: Bug 50

2006-12-19 Thread Pedro Araújo Chaves Jr.
On 12/19/06, Alexandre Julliard <[EMAIL PROTECTED]> wrote: Passing the DC is not an option, that's a private gdi32 structure that the driver doesn't know about. You shouldn't need to change the function signature in any case, it already takes an lpDx array, all you have to do is put better spacin

Re: Bug 50

2006-12-19 Thread Alexandre Julliard
"Pedro Araújo Chaves Jr." <[EMAIL PROTECTED]> writes: > Right now I can't think of another way around that bug except a patch that > big, but I think we could break it into two smaller ones: the first one > would change what must be changed for the second one ― the actual correction > ― to work. W

Bug 50

2006-12-18 Thread Pedro Araújo Chaves Jr.
First, sorry for the blank mail I accidentally sent earlier... my bad. Ok, so I have been assigned bug 50 [1] here at my job, and I'm trying to apply the patch [2] Keith Dunwoody proposed in June 2005, which fixed the issue but was rejected for technical reasons. Right now I can'

Bug 50

2006-12-18 Thread Pedro Araújo Chaves Jr.
-- "People think computers will keep them from making mistakes. They're wrong. With computers you make mistakes faster." (Adam Osborne)