Re: Add implementation of D3DRMVector* functions

2007-03-12 Thread Vijay Kiran Kamuju
Hi, Currently I dont have a wine repository, so that I could not apply and test it. No time to change it :( Next will check properly. Thanks, VJ On 3/12/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: "Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > This is a patch by David Adams, implementi

Re: Add implementation of D3DRMVector* functions

2007-03-12 Thread Vijay Kiran Kamuju
Hi, Can you update these comments to this bugzilla entry, #7442? Thanks, VJ On 3/12/07, H. Verbeet <[EMAIL PROTECTED]> wrote: On 12/03/07, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: > Hi, > > This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll > I am sending th

Re: Add implementation of D3DRMVector* functions

2007-03-12 Thread H. Verbeet
On 12/03/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: 3. the patch is extremely buggy in memory allocations: instead of allocating the space for an object it allocates the space only for a pointer. I'd suggest to allocate all the objects on the stack instead. Hmm, I looked over that.

Re: Add implementation of D3DRMVector* functions

2007-03-12 Thread H. Verbeet
On 12/03/07, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: Hi, This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll I am sending the patch to this mailing list as this was posted on bugzilla and awaiting review. A few comments: - * Foundation, Inc., 51 Franklin S

Re: Add implementation of D3DRMVector* functions

2007-03-12 Thread Dmitry Timoshkov
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll I am sending the patch to this mailing list as this was posted on bugzilla and awaiting review. 1. it's not really nice to send something with name attachment.cgi as