Re: Add dxdiag help message box

2009-09-19 Thread Brian Nguyen
Oops, removed the trailing space. On Sat, Sep 19, 2009 at 2:25 PM, Henri Verbeet wrote: > 2009/9/19 Brian Nguyen : > > Thanks for the suggestion; I didn't realize you could get a pointer to > the > > string itself. Here's an updated patch. I also changed the wording some > more > > to make it le

Re: Add dxdiag help message box

2009-09-19 Thread Henri Verbeet
2009/9/19 Brian Nguyen : > Thanks for the suggestion; I didn't realize you could get a pointer to the > string itself. Here's an updated patch. I also changed the wording some more > to make it less similar to the native dxdiag. > Works for me. You still have the trailing space though.

Re: Add dxdiag help message box

2009-09-19 Thread Brian Nguyen
Thanks for the suggestion; I didn't realize you could get a pointer to the string itself. Here's an updated patch. I also changed the wording some more to make it less similar to the native dxdiag. On Sat, Sep 19, 2009 at 12:05 PM, Henri Verbeet wrote: > 2009/9/18 Brian Nguyen : > > Here's an up

Re: Add dxdiag help message box

2009-09-19 Thread Austin English
On Fri, Sep 18, 2009 at 4:35 PM, Brian Nguyen wrote: > Here's an updated patch that stores the string in an En.rc resource file and > loads it using a wrapper for LoadString. How does this look? The text still matches Windows'. -- -Austin

Re: Add dxdiag help message box

2009-09-19 Thread Henri Verbeet
2009/9/18 Brian Nguyen : > Here's an updated patch that stores the string in an En.rc resource file and > loads it using a wrapper for LoadString. How does this look? > I think that should work, but how about something like this: static const WCHAR *DxDiag_LoadString(UINT id) { static const WC

Re: Add dxdiag help message box

2009-09-18 Thread Brian Nguyen
Here's an updated patch that stores the string in an En.rc resource file and loads it using a wrapper for LoadString. How does this look? On Fri, Sep 18, 2009 at 1:36 AM, Henri Verbeet wrote: > 2009/9/18 Brian Nguyen : > > Hm, okay. I just wanted to test the waters here; I'll rework this to use

Re: Add dxdiag help message box

2009-09-18 Thread Henri Verbeet
2009/9/18 Brian Nguyen : > Hm, okay. I just wanted to test the waters here; I'll rework this to use a > function that loads > a string from a resource file. Does the help message itself look okay? I > just used the message > provided by the native dxdiag app, but I could rework it if there are issu

Re: Add dxdiag help message box

2009-09-18 Thread Brian Nguyen
Hm, okay. I just wanted to test the waters here; I'll rework this to use a function that loads a string from a resource file. Does the help message itself look okay? I just used the message provided by the native dxdiag app, but I could rework it if there are issues with copyright or wine conventio

Re: Add dxdiag help message box

2009-09-17 Thread Austin English
On Thu, Sep 17, 2009 at 6:34 AM, Henri Verbeet wrote: > 2009/9/17 Brian Nguyen : >> +/* Thread-safe function for converting to wide char strings at runtime */ >> +LPWSTR PrintWide(LPWSTR buf, size_t len, const char *s) >> +{ >> +    size_t i; >> +    for (i = 0; i < len && *s != '\0'; i++, s++) {

Re: Add dxdiag help message box

2009-09-17 Thread Henri Verbeet
2009/9/17 Brian Nguyen : > +/* Thread-safe function for converting to wide char strings at runtime */ > +LPWSTR PrintWide(LPWSTR buf, size_t len, const char *s) > +{ > +size_t i; > +for (i = 0; i < len && *s != '\0'; i++, s++) { > +buf[i] = *s; > +} > +return buf; > +} That