"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
Fix the D3DRMAPI definitions (Dimitry's Comments)
Fix the inclusion of d3dtypes.h (Francois' Comments)
Where other comments has gone, into a black hole?
Changelog
----
Add d3drmdef.h header file, require
On Mon, 19 Mar 2007, Vijay Kiran Kamuju wrote:
[...]
> Add minimalistic d3drmdef.h
[...]
Something I just noticed:
+#include "d3dtypes.h"
This should be:
#include
If I remember correctly it's important in the public headers for
compiling Winelib in some circumstances. (I'm not saying this is
On 20/03/07, Dan Kegel <[EMAIL PROTECTED]> wrote:
Vijay wrote:
> We have made the tests and implementation.
> We are waiting for this to get into the tree.
> Just ironing out minor issues with our implementation.
> Once this gets in it would be easy to send in the
> implementation and tests.
You
Vijay wrote:
We have made the tests and implementation.
We are waiting for this to get into the tree.
Just ironing out minor issues with our implementation.
Once this gets in it would be easy to send in the
implementation and tests.
You need to submit them all together, I think.
- Dan
"Carl-Daniel Hailfinger" <[EMAIL PROTECTED]> wrote:
On 20.03.2007 09:37, Dmitry Timoshkov wrote:
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
I know its very tough to get patches done by newbies to get in, esp wine.
It's absolutely not hard to get patches accepted, be it Wine or any othe
On 20.03.2007 09:37, Dmitry Timoshkov wrote:
> "Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
>
>> I know its very tough to get patches done by newbies to get in, esp wine.
>
> It's absolutely not hard to get patches accepted, be it Wine or any other
> project. But it's absolutely required to li
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
I have a very tough luck getting in my patches.
eg: my wininet patches (1yr back, more testcases), comctl monthcal
patch(no testcase) and now this d3drm.
Please someone help David Adam and Me in this, most of the hardwork is
done by David.
I dont w
Hi,
Can somebody more experienced than me, please look into this?
Modify and Submit to the wine-patches, please anyone who is working on wined3d.
I and David Adam put a lotta effort making implementation and tests for d3drm.
So that we can make older games that use vector manipulations work,
ther
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
We have made the tests and implementation.
We are waiting for this to get into the tree.
Just ironing out minor issues with our implementation.
Once this gets in it would be easy to send in the implementation and tests.
How this could get in if y
Hi,
We have made the tests and implementation.
We are waiting for this to get into the tree.
Just ironing out minor issues with our implementation.
Once this gets in it would be easy to send in the implementation and tests.
Thanks,
VJ
PS:
-
If implementation and tests are needed, will be se
Vijay wrote:
Resend. Please let me why this one has been dropped.
I'd guess it's because there's no code in the tree that
needs it yet, and no tests for it?
- Dan
Hi,
Please ignore the this one.
I am sending a new one.
I wrongly named the header file, effects of late night coding
bye,
VJ
On 3/13/07, Francois Gouget <[EMAIL PROTECTED]> wrote:
On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote:
> Changelog
> ---
> Add minimalistic d3drmdef.h
>
> ex
On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote:
> Changelog
> ---
> Add minimalistic d3drmdef.h
>
> extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR,
> LPD3DVECTOR);
Two nitpicks:
Wine's headers usually don't specify extern (it's implicit).
If there's a large lis
Vijay wrote:
Add minimalistic d3drmdef.h
But why? None of the code in wine currently
needs it. Maybe you should submit it together
with the first bit of code that needs it.
--
Wine for Windows ISVs: http://kegel.com/wine/isv
Hi,
I have sent the fix for the problematic file, which I used a base.
There a bug in bugzilla 7386
(http://bugs.winehq.org/show_bug.cgi?id=7386) , which needs
implementation of D3DRM's vector functions.
These are pure math functions. I am improving the fix given in
bugzilla 7442 (http://bugs.win
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
> +#ifndef __D3DRMDEFS_H__
> +#define __D3DRMDEFS_H__
I saw d3dtypes.h and other d3d header files, its defined like this
only, no wine prefix has been added.
No, it's not defined like this.
That's exactly how microsoft does it, this is not ho
Hi
On 3/12/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
> I thought for completeness, we provide the entire header.
> I did write all that with the help DirectX SDK. (Phew It took me 3 hrs
> to type it)
If it ends up as an almost exact copy of
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote:
I thought for completeness, we provide the entire header.
I did write all that with the help DirectX SDK. (Phew It took me 3 hrs
to type it)
If it ends up as an almost exact copy of a microsoft header it's not worth an
effort.
+#ifndef __D3DRM
Hi,
I thought for completeness, we provide the entire header.
I did write all that with the help DirectX SDK. (Phew It took me 3 hrs
to type it)
Thanks,
VJ
On 3/12/07, Dan Kegel <[EMAIL PROTECTED]> wrote:
vijay wrote:
> [complete d3drmdef.h]
It seems premature to check that in without any cod
vijay wrote:
[complete d3drmdef.h]
It seems premature to check that in without any code that uses it.
Also, did you really write all that yourself?
- Dan
20 matches
Mail list logo
