"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote:
>> Perhaps there is something less hacky way like GdiFlush() which is more
>> appropriate for this.
> I created a patch that does GdiFlush and waits up to .5 seconds after
> a resolution change, are you ok with that?
Perhaps you could investigate f
2008/2/13, Dmitry Timoshkov <[EMAIL PROTECTED]>:
> "Maarten Lankhorst" <[EMAIL PROTECTED]> wrote:
>
> > This makes the tests pass on my pc.
>
> Perhaps there is something less hacky way like GdiFlush() which is more
> appropriate for this.
I created a patch that does GdiFlush and waits up to .5
Hi Dmitry,
2008/2/13, Dmitry Timoshkov <[EMAIL PROTECTED]>:
> "Maarten Lankhorst" <[EMAIL PROTECTED]> wrote:
>
> > This makes the tests pass on my pc.
>
> Perhaps there is something less hacky way like GdiFlush() which is more
> appropriate for this.
I tested GdiFlush to do an XSync and XFlush,
OK. I still think he should put a FIXME remark in the test-case,
and document why Sleep() is needed. Someone might fix the driver
someday.
The only reason i yelled "alert!", is that i have seen so much bad code
which has come to a state where the are Sleep(143) here and Sleep(1332)
there, where n
Am Mittwoch, 13. Februar 2008 03:11:24 schrieb Peter Dons Tychsen:
> Eh, this does not seem like a proper way to get a unit test to pass.
>
> Sleep()... that leads to the dark side! :-)
I talked to Maarten on IRC about this. The problem seems to be that his
monitor takes ages to mode switch, but C
On Wednesday 13 February 2008 03:11:24 Peter Dons Tychsen wrote:
> The string "This makes the tests pass on my pc" isn't very good either.
> What system?
Given that the default mode for the tests in the last years has been "Needs to
pass on Alexandre's system", I don't think it's that bad. ;)
C
"Maarten Lankhorst" <[EMAIL PROTECTED]> wrote:
> This makes the tests pass on my pc.
Perhaps there is something less hacky way like GdiFlush() which is more
appropriate for this.
--
Dmitry.
Eh, this does not seem like a proper way to get a unit test to pass.
Sleep()... that leads to the dark side! :-)
Why does it need a Sleep()? If its failing on Wine, then shouldn't it be
fixed in the libs? And if its on orig-winxp-vista then there must be a
better way to wait? Or no?
The string "
Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst:
> This makes the tests pass on my pc.
d3d8 might need it as well
