Markus Hitter <[EMAIL PROTECTED]> writes:
> It's returned, but won't show up in the console. I thought the idea
> of TRACE()s is to allow some sort of cheap printf()-style debugging
> and should be complete.
It can't be complete, that would make it totally unmanageable, and make
the code unre
Am 26.08.2008 um 01:33 schrieb Juan Lang:
> It seems your tolerance for reworking patches is rather low.
Currently, yes. I'll have to take a breath.
> -if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER;
> +if (!attr || !attr->ObjectName)
> +{
> +TRACE("returni
> So, why not fix this? Please push the patch trough Wine's patch accepting
> mechanism yourself, I'm currently somewhat sick of it.
It seems your tolerance for reworking patches is rather low. You must
be willing to rework patches until they're correct to have many
committed around here. I've p
Am 25.08.2008 um 21:39 schrieb James Hawkins:
As the code stands now, regardless of your patch, the check for
NULL attr on line 154 of dlls/kernel32/file.c will never be hit
because we will crash in the TRACE on line 148 of dlls/kernel32/
file.c.
Now I got it. You aren't talking about the
On Mon, Aug 25, 2008 at 2:29 PM, Markus Hitter <[EMAIL PROTECTED]> wrote:
>
> Am 25.08.2008 um 17:58 schrieb James Hawkins:
>
>> On Mon, Aug 25, 2008 at 3:12 AM, Markus Hitter <[EMAIL PROTECTED]> wrote:
>>>
>>> Am 25.08.2008 um 01:31 schrieb James Hawkins:
>>>
2008/8/24 Markus Hitter <[EMAIL P
Am 25.08.2008 um 17:58 schrieb James Hawkins:
> On Mon, Aug 25, 2008 at 3:12 AM, Markus Hitter <[EMAIL PROTECTED]>
> wrote:
>>
>> Am 25.08.2008 um 01:31 schrieb James Hawkins:
>>
>>> 2008/8/24 Markus Hitter <[EMAIL PROTECTED]>:
>>>
>>> -if (!attr || !attr->ObjectName) return
>>> STATUS_IN
On Mon, Aug 25, 2008 at 3:12 AM, Markus Hitter <[EMAIL PROTECTED]> wrote:
>
> Am 25.08.2008 um 01:31 schrieb James Hawkins:
>
>> 2008/8/24 Markus Hitter <[EMAIL PROTECTED]>:
>>>
>>
>> +if (!attr || !attr->ObjectName)
>> +{
>> +TRACE("returning STATUS_INVALID_PARAMETER\n");
>> +
Am 25.08.2008 um 01:31 schrieb James Hawkins:
> 2008/8/24 Markus Hitter <[EMAIL PROTECTED]>:
>>
>
> +if (!attr || !attr->ObjectName)
> +{
> +TRACE("returning STATUS_INVALID_PARAMETER\n");
> +return STATUS_INVALID_PARAMETER;
> +}
>
>
> These are all very useless TRACES,
2008/8/24 Markus Hitter <[EMAIL PROTECTED]>:
>
+if (!attr || !attr->ObjectName)
+{
+TRACE("returning STATUS_INVALID_PARAMETER\n");
+return STATUS_INVALID_PARAMETER;
+}
These are all very useless TRACES, except for possibly the returned
handle value. You should be abl
2008/8/18 Michael Karcher <[EMAIL PROTECTED]>:
> Another review.
>
> Am Sonntag, den 20.07.2008, 22:42 +0200 schrieb Markus Hitter:
>> Similar to NtReadFile and NtWriteFile, NtCreateFile should trace
>> return values on request. Providing the file handle allows to map
>> read/write requests to the
Another review.
Am Sonntag, den 20.07.2008, 22:42 +0200 schrieb Markus Hitter:
> Similar to NtReadFile and NtWriteFile, NtCreateFile should trace
> return values on request. Providing the file handle allows to map
> read/write requests to the corresponding file name.
Seems very sensible. Your
11 matches
Mail list logo
