Re: ADVAPI32: Start test for service tests

2007-06-05 Thread Alexandre Julliard
"Rolf Kalbermatter" <[EMAIL PROTECTED]> writes: > Go figure. To me it seems they messed up with the conversion from Widechar to > ASCII when needing to calculate the needed size. Unless they use some other > function than WideCharToMultiByte() it couldn't be for avoiding an extra > buffer > alloc

RE: ADVAPI32: Start test for service tests

2007-06-04 Thread Rolf Kalbermatter
James Hawkins [mailto:[EMAIL PROTECTED] wrote: >...and msdn is wrong a lot, but that doesn't mean the check is right. >If the value you get is 1, then check exactly for 1. I can currently only check on XP and the behaviour I see there does seem strange to me. It should rather return with some err

Re: ADVAPI32: Start test for service tests

2007-05-21 Thread James Hawkins
On 5/21/07, Rolf Kalbermatter <[EMAIL PROTECTED]> wrote: James Hawkins [mailto:[EMAIL PROTECTED] wrote: >+ok(size <= 1, "size should be <= 1 was %d!", size); > >This is a bad test. According to msdn, GetServiceDisplayName does not >modify lpcchBuffer on error, so size should be exactly 0.

RE: ADVAPI32: Start test for service tests

2007-05-21 Thread Rolf Kalbermatter
James Hawkins [mailto:[EMAIL PROTECTED] wrote: >+ok(size <= 1, "size should be <= 1 was %d!", size); > >This is a bad test. According to msdn, GetServiceDisplayName does not >modify lpcchBuffer on error, so size should be exactly 0. MSDN says a lot of things. On my XP SP2 it returns 1 as siz

Re: ADVAPI32: Start test for service tests

2007-05-20 Thread James Hawkins
On 5/20/07, Rolf Kalbermatter <[EMAIL PROTECTED]> wrote: Changelog dlls/advapi32/tests/Makefile.in dlls/advapi32/tests/service.c Start test for service tests License: X11/LGPL This test will crash without the previous patch "Return error on NULL service name to GetServiceDisplayNameA/W"