Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread James Hawkins
On Thu, Dec 17, 2009 at 1:25 PM, Jason Green wrote: > We both work for TransGaming, and these patches are officially from the > company. > Ok, thanks for the info!

Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread Jason Green
We both work for TransGaming, and these patches are officially from the company. On Dec 17, 2009, at 4:22 PM, James Hawkins wrote: > On Thu, Dec 17, 2009 at 1:19 PM, Jason Green wrote: >> Sorry, should have copied Eric van Beurden on this earlier. His name & >> email are in the patch on the Fr

Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread James Hawkins
On Thu, Dec 17, 2009 at 1:19 PM, Jason Green wrote: > Sorry, should have copied Eric van Beurden on this earlier.  His name & email > are in the patch on the From: line. > To clarify my question, are you guys working at a company that is contributing to Wine, or are you contributing for fun, etc

Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread Jason Green
Sorry, should have copied Eric van Beurden on this earlier. His name & email are in the patch on the From: line. On Dec 17, 2009, at 4:07 PM, James Hawkins wrote: > On Thu, Dec 17, 2009 at 12:56 PM, Jason Green wrote: >> Yeah, I was just forwarding this from one of our other internal developer

Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread James Hawkins
On Thu, Dec 17, 2009 at 12:56 PM, Jason Green wrote: > Yeah, I was just forwarding this from one of our other internal developers.   > I just went back and noticed that he had a note here which said, "This patch > isn't really necessary, and could be left off the submission to WineHQ." > I'm jus

Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread Jason Green
Yeah, I was just forwarding this from one of our other internal developers. I just went back and noticed that he had a note here which said, "This patch isn't really necessary, and could be left off the submission to WineHQ." :-) On Dec 17, 2009, at 3:46 PM, Juan Lang wrote: > Hi Jason, > >

Re: [usp10 1/6] Fix an uninitialized static variable.

2009-12-17 Thread Juan Lang
Hi Jason, -static const ABC nil; +static const ABC nil = {0}; This has no effect, as static variables are implicitly initialized to 0 anyway. It might be a little less surprising this way.. --Juan