Re: [shellpath.c] Taking into account the profile value set in wine config file

2004-11-09 Thread Juan Lang
--- Fabrice Ménard <[EMAIL PROTECTED]> wrote: > Excuse me to reactivate this debate, but I had'nt understood all your > thoughts. > Has there been a consensus on this spot ? > Should I resend the patch, change it or get rid of it ? No need to apologize. Alexandre's most recent suggestion is the c

Re: [shellpath.c] Taking into account the profile value set in wine config file

2004-11-09 Thread Fabrice Ménard
Le Mardi 02 Novembre 2004 21:03, Juan Lang a écrit : > --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > The proper fix is to ensure that the environment is set up properly; > > shell32 shouldn't have to duplicate the environment registry support. > > Yes, but it's a chicken-and-egg problem.

Re: [shellpath.c] Taking into account the profile value set in wine config file

2004-11-02 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > Are you suggesting setupapi special case registry value setting so that if > it recognizes the key as affecting the environment, it should set the > variable on the spot? Or do you have another suggestion? No, setupapi should respect the environment variab

Re: [shellpath.c] Taking into account the profile value set in wine config file

2004-11-02 Thread Juan Lang
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > The proper fix is to ensure that the environment is set up properly; > shell32 shouldn't have to duplicate the environment registry support. Yes, but it's a chicken-and-egg problem. The registry for the environment has been set up right, but the

Re: [shellpath.c] Taking into account the profile value set in wine config file

2004-11-02 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > You've exposed some softness in my thinking in this patch. Like I > mentioned in the comments for it, _SHExpandEnvironmentVariables exists > because the environment isn't actually set up during wine install time. I > didn't think to look up the values in t

Re: [shellpath.c] Taking into account the profile value set in wine config file

2004-11-02 Thread Juan Lang
You've exposed some softness in my thinking in this patch. Like I mentioned in the comments for it, _SHExpandEnvironmentVariables exists because the environment isn't actually set up during wine install time. I didn't think to look up the values in the registry. I also didn't register some of th