Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Huang, Zhangrong
2008/6/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > > That definitely will break any charset specified in the font (like > symbol, russian, etc.) in CJK locale. Most likely what happens is > a font linking/substituting for ANSI_CHARSET. > I think it doesn't. If users create font with ANSI_CHARSET or

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Dmitry Timoshkov
"Huang, Zhangrong" <[EMAIL PROTECTED]> wrote: > I mean fix GdiGetCodePage like: > > if (charset == ANSI_CHARSET || charset == DEFAULT_CHARSET) > { > cp = GetACP(); > if (cp == 936 || cp == 950 || cp == .) > return cp; > >else (TranslateCharsetInfo()) > >

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Huang, Zhangrong
2008/6/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > >> And could we hardcode CJK codepages to fix GdiGetCodePage? > > What do you mean? I mean fix GdiGetCodePage like: if (charset == ANSI_CHARSET || charset == DEFAULT_CHARSET) { cp = GetACP(); if (cp == 936 || cp == 950 || cp == .)

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Dmitry Timoshkov
"Huang, Zhangrong" <[EMAIL PROTECTED]> wrote: > Sorry, I didn't get that. These tests will pass on Windows > 2000/XP/Vista in different languages except Wine, there are no failing > tests. Should I mark these as todo_wine? If todo_wine doesn't mangle the test too much that's of cause more preferr

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Huang, Zhangrong
Sorry, I didn't get that. These tests will pass on Windows 2000/XP/Vista in different languages except Wine, there are no failing tests. Should I mark these as todo_wine? And could we hardcode CJK codepages to fix GdiGetCodePage? Thanks. 2008/6/24 Dmitry Timoshkov <[EMAIL PROTECTED]>: > In the bu

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.

2008-06-24 Thread Dmitry Timoshkov
"Huang, Zhangrong" <[EMAIL PROTECTED]> wrote: > As discussed in Bug 4065 (http://bugs.winehq.org/show_bug.cgi?id=4065) In the bug 4065 I suggested to comment out the failing tests before sending it to wine-patches. -- Dmitry.