Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From 165aeb4aa1350b6d26be268ca7e4136058484069 Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 22:09:47 +0300 Subject: [ntdll] Move search for assemblyIdentity element Function for manifest parsing tried search for assemblyIdentity element only if it placed in begin of a man

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From c59dbc8de90398c03e7cc44124a5902b1b2d8fc7 Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 22:27:09 +0300 Subject: [ntdll] lookup_assembly function should returns STATUS_SUCCESS Expected result of function is STATUS_SUCCESS if no errors occurred, but it returned zero in

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From a7af98e6d2d185614d92c02c817ac74382c1b35c Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 21:32:42 +0300 Subject: [ntdll] Free memory for type field of an asembly_identity Memory for this field was allocated and never freed --- dlls/ntdll/actctx.c |1 + 1 files cha

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From 4f895878f85988c292454662ae07ba3e72d7e7ba Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 21:25:52 +0300 Subject: [ntdll] Care about arch and name fields in assembly_identity structure On parsing of a manifest is possible access to zero address and crash. It's happens

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
Austin English wrote: On Wed, Mar 11, 2009 at 2:40 PM, Roman Mindalev wrote: Jacek Caban wrote: Hi Roman, On parsing of manifest in PE module is possible access to zero address and crash. It's happens because not all manifest attributes can be specified and pointers in assembly_identity stru

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Austin English
On Wed, Mar 11, 2009 at 2:40 PM, Roman Mindalev wrote: > Jacek Caban wrote: >> >> Hi Roman, >> >>> On parsing of manifest in PE module is possible access to zero address >>> and crash. It's happens because not all manifest attributes can be >>> specified and pointers in assembly_identity structure

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
Jacek Caban wrote: Hi Roman, On parsing of manifest in PE module is possible access to zero address and crash. It's happens because not all manifest attributes can be specified and pointers in assembly_identity structure can be uninitialized. This patch adds function for setting empty strings i

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Jacek Caban
Hi Roman, On parsing of manifest in PE module is possible access to zero address and crash. It's happens because not all manifest attributes can be specified and pointers in assembly_identity structure can be uninitialized. This patch adds function for setting empty strings in structure elements