Re: [moniker 2] Fix FileMoniker::Load/Save

2005-06-02 Thread Richard Cohen
Mike McCormack wrote: > In C, variables are traditionally lower case, and macros are upper case. ... but constants are also traditionally upper case. :) Robert Shearman wrote: ... paths that exist are saved with the Unicode version of their path name, but paths that don't are saved without.

Re: [moniker 2] Fix FileMoniker::Load/Save

2005-06-02 Thread Robert Shearman
On Thursday 02 June 2005 09:47, Richard Cohen wrote: > Changelog >- Base FileMonikerImpl_Save() on XP >- Correct handling of Unicode strings & multibyte locales >- More error checking >- Change ERR to WARN >- Match Windows quick & dirty estimate for GetSizeMax() Hi Richard, We

Re: [moniker 2] Fix FileMoniker::Load/Save

2005-06-02 Thread Mike McCormack
Nice patch, and nice test case. -DWORD constant1 = 0xDEAD; /* these constants are detected after analysing the data structure written by */ -WORD constant2 = 0x3;/* FileMoniker_Save function in a windows program system */ +DWORD DEAD = 0xDEAD; /* Constants