Re: [dcom 1.2] Implement dispatch variant marshalling

2003-09-04 Thread Dimitrie O. Paun
On 4 Sep 2003, Mike Hearn wrote: > Another possibility is to have a wine convenience macro, similar to the > glib g_return_if_fail() macro, that works for instance: > > wine_return_if_fail_hr(CoDoSomethingCOMRelated()) > > which expands to > { >HRESULT hr = CoDoSomethingCOMRelated() >if

Re: [dcom 1.2] Implement dispatch variant marshalling

2003-09-04 Thread Dimitrie O. Paun
On 4 Sep 2003, Mike Hearn wrote: > I removed the use of asserts to check the results, and replaced them > with ERRs. > + working_mem = GlobalAlloc(0, size); > + if (!working_mem) { > +ERR("failed to get a global alloc\n"); > +return oldpos; > + } I don't think this is such a good idea

Re: [dcom 1.2] Implement dispatch variant marshalling

2003-09-04 Thread Mike Hearn
On Thu, 2003-09-04 at 20:53, Dimitrie O. Paun wrote: > I'd prefer we don't have there -- they really clutter the code, > provide a bad example to follow, and provide little, if any, > benefit. What you can do is put some strategic TRACEs that would > help someone who knows the code to identify the