Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-10 Thread Alexandre Julliard
Paul Vriens <[EMAIL PROTECTED]> writes: > The question that remains is should the full -tests be able to be > compiled > and run or should we have this to be correct for every single test? I mean > that > are no issues if you compile the whole comctl32 "testsuite". It's a good idea to keep ea

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-10 Thread Paul Vriens
Mikołaj Zalewski wrote: > >> If LoadLibrary is indeed needed it should be accompanied with a >> FreeLibrary and we probably need a comment for the why as well. > > Does it matter if we call FreeLibrary on the library we are testing? I > don't think we will be able to free it before the end of

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-10 Thread Mikołaj Zalewski
> If LoadLibrary is indeed needed it should be accompanied with a > FreeLibrary and we probably need a comment for the why as well. Does it matter if we call FreeLibrary on the library we are testing? I don't think we will be able to free it before the end of the tests when anyhow it will be

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-09 Thread Paul Vriens
Mikołaj Zalewski wrote: > I've changed GetModuleHandle to LoadLibrary because when I compiled > only tests/rebar.c as standalone, the comctl32 wasn't loaded and > GetModuleHandle returned NULL. Are there advantages from using > GetModuleHandle? > > Mikołaj Zalewski > Well, I was checking whet

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA

2008-03-09 Thread Mikołaj Zalewski
I've changed GetModuleHandle to LoadLibrary because when I compiled only tests/rebar.c as standalone, the comctl32 wasn't loaded and GetModuleHandle returned NULL. Are there advantages from using GetModuleHandle? Mikołaj Zalewski