Re: [cmd] Don't change case of the batch filename

2010-02-18 Thread Alexandre Julliard
Paul Vriens writes: > On 02/18/2010 03:33 PM, Alexandre Julliard wrote: >> Paul Vriens writes: >> In any case the test environment needs to be comparing paths in a case-insensitive way, it doesn't make sense to require exact case. >>> >>> So the memcmp needs to change into some strcmp

Re: [cmd] Don't change case of the batch filename

2010-02-18 Thread Paul Vriens
On 02/18/2010 03:33 PM, Alexandre Julliard wrote: Paul Vriens writes: In any case the test environment needs to be comparing paths in a case-insensitive way, it doesn't make sense to require exact case. So the memcmp needs to change into some strcmp form? Yes, though you probably need Comp

Re: [cmd] Don't change case of the batch filename

2010-02-18 Thread Alexandre Julliard
Paul Vriens writes: >> In any case the test environment needs to be comparing paths in a >> case-insensitive way, it doesn't make sense to require exact case. > > So the memcmp needs to change into some strcmp form? Yes, though you probably need CompareString. -- Alexandre Julliard julli...@wi

Re: [cmd] Don't change case of the batch filename

2010-02-18 Thread Paul Vriens
On 02/18/2010 02:51 PM, Alexandre Julliard wrote: Paul Vriens writes: diff --git a/programs/cmd/batch.c b/programs/cmd/batch.c index 28744d4..6cb732c 100644 --- a/programs/cmd/batch.c +++ b/programs/cmd/batch.c @@ -91,7 +91,7 @@ void WCMD_batch (WCHAR *file, WCHAR *command, int called, WCHAR

Re: [cmd] Don't change case of the batch filename

2010-02-18 Thread Alexandre Julliard
Paul Vriens writes: > diff --git a/programs/cmd/batch.c b/programs/cmd/batch.c > index 28744d4..6cb732c 100644 > --- a/programs/cmd/batch.c > +++ b/programs/cmd/batch.c > @@ -91,7 +91,7 @@ void WCMD_batch (WCHAR *file, WCHAR *command, int called, > WCHAR *startLabel, HAN >prev_context = cont

Re: [cmd] Don't change case of the batch filename

2010-02-18 Thread Paul Vriens
On 02/18/2010 02:35 PM, Paul Vriens wrote: Hi, This should fix the test failures for Wine (on test.winehq.org). Not sure how to write a (simple) test for this. The test is there in fact but it will only show up on test.winehq.org or when doing a "make batch.ok" from a directory with an uppercas