Re: [advpack/setupapi] LaunchINFSection

2005-11-20 Thread Robert Shearman
Raphael wrote: + if (!bTest) return E_FAIL; Don't use E_FAIL. Try to return a proper error code, preferably using what native returns in this circumstance by adding a test case. see http://msdn.microsoft.com/workshop/delivery/download/overview/launchinfsectionex.asp Native

Re: [advpack/setupapi] LaunchINFSection

2005-11-20 Thread Raphael
Hi, On Thursday 17 November 2005 04:45, Robert Shearman wrote: > I have a few comments: You too :) > > Why bother with the assert? You'll crash more nicely by just > dereferencing the NULL pointer. At least then you'll get a backtrace in > the debugger. because i used to use assert in many of m

Re: [advpack/setupapi] LaunchINFSection

2005-11-20 Thread Raphael
On Thursday 17 November 2005 01:59, Dimi Paun wrote: > On Wed, 2005-11-16 at 23:56 +0100, Raphael wrote: > > +if (!bRet) { > > + ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src), > > debugstr_w(dst)); > > +} > > You shouldn't issue ERR if the function can deal with > the error cond

Re: [advpack/setupapi] LaunchINFSection

2005-11-20 Thread Raphael
Hi, > I appreciate your work on advpack, but some comments that might help > get it accepted more easily: > > * separate the patch into as many independent chunks as you can. It > seems like each function you implement can be sent in separate and > linearly. Yes, but as they are really small ch

Re: [advpack/setupapi] LaunchINFSection

2005-11-20 Thread Raphael
On Thursday 17 November 2005 15:33, Markus Amsler wrote: > Hi, Hi, > James Hawkins wrote: > >* it would help to add test cases wherever you can even if it's just > >to check how the function handles parameters. > > I'm also working on advpack inf install functions. Perhaps we should > coordinate

Re: [advpack/setupapi] LaunchINFSection

2005-11-17 Thread Markus Amsler
Hi, James Hawkins wrote: * it would help to add test cases wherever you can even if it's just to check how the function handles parameters. I'm also working on advpack inf install functions. Perhaps we should coordinate our work: Here my current Roadmap: 1. get tests into CVS (see below)

Re: [advpack/setupapi] LaunchINFSection

2005-11-16 Thread Robert Shearman
Raphael wrote: Changelog: - semi implementation of advpack APIs LaunchINFSection/LaunchINFSectionEx - semi implementation of advpack API ExtractFiles - setupapi: correct and check pExtractFiles return code I have a few comments:

Re: [advpack/setupapi] LaunchINFSection

2005-11-16 Thread Dimi Paun
On Wed, 2005-11-16 at 23:56 +0100, Raphael wrote: > +if (!bRet) { > + ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src), > debugstr_w(dst)); > +} You shouldn't issue ERR if the function can deal with the error condition. Just return the appropriate error code. ERR is to signal a ca

Re: [advpack/setupapi] LaunchINFSection

2005-11-16 Thread James Hawkins
On 11/16/05, Raphael <[EMAIL PROTECTED]> wrote: > > Changelog: > - semi implementation of advpack APIs LaunchINFSection/LaunchINFSectionEx > - semi implementation of advpack API ExtractFiles > - setupapi: correct and check pExtractFiles return code > I appreciate your work on advpack, but s