Re: [WINED3D] QueryInterface corrections

2006-05-07 Thread Stefan Dösinger
> > Well, WINED3DERR_INVALIDCALL == D3DERR_INVALIDCALL. I've added those > > return values to the wined3d headers so I can check in ddraw for the > > return values. A lot of retvals from wined3d are in d3d8 / d3d9 and do > > not exist in ddraw. > > > > Just wanted to point that out. > > > > Stefan

Re: [WINED3D] QueryInterface corrections

2006-05-07 Thread H. Verbeet
On 07/05/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > - Even if GetContainer should return D3DERR_INVALIDCALL (not > WINED3D_INVALIDCALL!) ... Well, WINED3DERR_INVALIDCALL == D3DERR_INVALIDCALL. I've added those return values to the wined3d headers so I can check in ddraw for the return valu

Re: [WINED3D] QueryInterface corrections

2006-05-07 Thread Stefan Dösinger
> - Even if GetContainer should return D3DERR_INVALIDCALL (not > WINED3D_INVALIDCALL!) ... Well, WINED3DERR_INVALIDCALL == D3DERR_INVALIDCALL. I've added those return values to the wined3d headers so I can check in ddraw for the return values. A lot of retvals from wined3d are in d3d8 / d3d9 and

Re: [WINED3D] QueryInterface corrections

2006-05-07 Thread H. Verbeet
On 06/05/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > - At least for d3d9, GetContainer returns E_NOINTERFACE on Windows. I > verified that when I rewrote part of the function some time ago, and I > just did again. I originally intended to add a test for that, but > well, guess I forgot about i

Re: [WINED3D] QueryInterface corrections

2006-05-06 Thread Ivan Gyurdiev
H. Verbeet wrote: On 25/04/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: H. Verbeet wrote: > On 25/04/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > >> (2) write a NULL argument on no match. >> >> This patch corrects those issues, and also changes GetContainer() for >> surfaces and volumes to use

Re: [WINED3D] QueryInterface corrections

2006-05-06 Thread H. Verbeet
On 25/04/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: H. Verbeet wrote: > On 25/04/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > >> (2) write a NULL argument on no match. >> >> This patch corrects those issues, and also changes GetContainer() for >> surfaces and volumes to use the return value a

Re: [WINED3D] QueryInterface corrections

2006-04-25 Thread Ivan Gyurdiev
H. Verbeet wrote: On 25/04/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: (2) write a NULL argument on no match. This patch corrects those issues, and also changes GetContainer() for surfaces and volumes to use the return value as MSDN specifies (WINED3D_INVALIDCALL), not E_NOINTERFACE on fail

Re: [WINED3D] QueryInterface corrections

2006-04-25 Thread H. Verbeet
On 25/04/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: > (2) write a NULL argument on no match. > > This patch corrects those issues, and also changes GetContainer() for > surfaces and volumes to use the return value as MSDN specifies > (WINED3D_INVALIDCALL), not E_NOINTERFACE on failure. Did you ve