On Wednesday 14 June 2006 17:52, Juan Lang wrote:
> Hi Christian,
Hi Juan,
>
> > I want to make a generic setupapi.dll and I will remove old serial
> > device list, but as too big patches wont get accepted, I will do this in
> > one of my next patches.
>
> I put that hacky serial device list in the
Hi Christian,
> I want to make a generic setupapi.dll and I will remove old serial
> device list, but as too big patches wont get accepted, I will do this in
> one of my next patches.
I put that hacky serial device list in there. I don't actually use the
app that fixed under Wine, as 1) Wine's
On Wednesday 14 June 2006 01:45, Detlef Riekenberg wrote:
Hi Detlef
> Hi Christian Gmeiner:
> > Sorry for the new version, but i got rid of the whitspace stuff and also
> > added a check if Reserved != NULL.
> >
> > I hope that this patch is ready to commit now.
>
> +if (MachineName != NULL)
Hi Christian Gmeiner:
> Sorry for the new version, but i got rid of the whitspace stuff and also
> added a check if Reserved != NULL.
>
> I hope that this patch is ready to commit now.
+if (MachineName != NULL)
+{
+FIXME("remote support is not implemented");
+goto cleanup
Hi Christian, thanks for working on setupapi, it could use some help. Huw
already commnented on your patch, I have a couple more:
+if (!list) {
+goto cleanup;
+}
The style in this file has opening braces on lines of their own, e.g.:
if (hInf == INVALID_HANDLE_VALUE)
{
On Tue, Jun 13, 2006 at 03:42:22PM +0200, Christian Gmeiner wrote:
> diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
> index f402f00..c24ae1e 100644
> --- a/dlls/setupapi/devinst.c
> +++ b/dlls/setupapi/devinst.c
> HDEVINFO WINAPI
> -SetupDiCreateDeviceInfoListExW(const GUID *ClassG