Re: [RFC] gameux.dll partial implementation

2010-07-13 Thread Vincent Povirk
Whew, last one. _FindGameByGDFBinaryPathInScope doesn't free lpData. It also never returns S_FALSE, but I see you fixed that later. You might want to add a test for GetGameStatistics in the case where a game is installed for all users or not installed at all. That should exercise the S_FALSE case

Re: [RFC] gameux.dll partial implementation

2010-07-13 Thread Mariusz PluciƄski
Hello First, thank you very much for checking my code. That's good to know my design is valid and I can continue creating code in this way. Of course, I know that my code will probably be rejected on the beginning, but it's still better for me when someone reviews my code, than working completely w

Re: [RFC] gameux.dll partial implementation

2010-07-10 Thread Vincent Povirk
+if( CompareStringW(LOCALE_INVARIANT, 0, bstrElementName, nElementNameLen, sNodeExtendedProperties, lstrlenW(sNodeExtendedProperties)) == CSTR_EQUAL) I think you can get away with an lstrcmpW here. Yes, technically it can behave differently depending on locale, but you're doing a case-sens

Re: [RFC] gameux.dll partial implementation

2010-07-09 Thread Vincent Povirk
Overall, I don't feel this series is "ready" yet, or that it will be ready if you address all of my comments. I'm intentionally keeping quiet about some things because I think it will be better for you to address them when the code freeze is over and you can send things to wine-patches. This is mos