Maarten Lankhorst <[EMAIL PROTECTED]> writes:
> +
> + if (!S_ISCHR (st.st_mode)) {
> + ERR("%s: Not a device\n", device);
> + CoTaskMemFree(capBox);
> + return E_FAIL;
> + }
>
> >
> >Same here.
> >
> No, /dev/video* should never be an ordinary file,
Dimi Paun wrote:
On Fri, 2005-05-20 at 12:26 +0200, Maarten Lankhorst wrote:
What do you suggest then ... fprintf(stderr?
Absolutely not. :) But there are other options available:
TRACE/WARN/FIXME. There's also MESSAGE, but it should be
used *very* little. Also remember that most people wil
On Fri, 2005-05-20 at 12:26 +0200, Maarten Lankhorst wrote:
> What do you suggest then ... fprintf(stderr?
Absolutely not. :) But there are other options available:
TRACE/WARN/FIXME. There's also MESSAGE, but it should be
used *very* little. Also remember that most people will
not see MESSAGE()s a
On Fri, 2005-05-20 at 10:37 +0200, Andreas Mohr wrote:
> > > + ERR("Tinkerer detected? Thou shalt not define HAVE_V4L2
> \n");
> > > + CoTaskMemFree(capBox);
> > > + close(capBox->fd);
> > > + return E_FAIL;
> >
> > This is a FIXME.
> It's not. His comments indicate that he has
Hi,
On Thu, May 19, 2005 at 09:20:25PM -0400, Dimi Paun wrote:
> On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote:
> > +
> > + capBox->fd = open(device, O_RDWR | O_NONBLOCK);
> > + if (capBox->fd == -1) {
> > + ERR("%s: Failed to open: %s\n", device, strerror(errno));
> > +
Dimi Paun wrote:
On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote:
m3h, v4l driver for vfwcapture.. please leave the ERR notice on
initialisation intact, thank you :)
I think you've overusing ERR(). ERR() should be called
to signal an internal error such as inconsistent state,
no
On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote:
> m3h, v4l driver for vfwcapture.. please leave the ERR notice on
> initialisation intact, thank you :)
I think you've overusing ERR(). ERR() should be called
to signal an internal error such as inconsistent state,
not something that the
