Re: [PATCH try4] wininet: Added support for persistent HTTP connections

2011-05-06 Thread Jacek Caban
On 05/06/11 13:17, Alexandre Julliard wrote: > Jacek Caban writes: > >> +/* FIXME: do the check also for SSL connections */ >> +if(!netconn->useSSL) { >> +res = NETCON_recv(netconn, &b, 1, MSG_PEEK|MSG_DONTWAIT, &len); >> +if((res == ERROR_SUCCESS && len ==

Re: [PATCH try4] wininet: Added support for persistent HTTP connections

2011-05-06 Thread Alexandre Julliard
Jacek Caban writes: > +/* FIXME: do the check also for SSL connections */ > +if(!netconn->useSSL) { > +res = NETCON_recv(netconn, &b, 1, MSG_PEEK|MSG_DONTWAIT, &len); > +if((res == ERROR_SUCCESS && len == 1) || res == WSAEWOULDBLOCK) > +brea

Re: [PATCH try4] wininet: Added support for persistent HTTP connections

2011-05-06 Thread Alexandre Julliard
Jacek Caban writes: > try4: Check idle connection before using it in an attempt to catch > closed connection sooner, avoiding some request resends. It hopefully > fixes observed problem with tests. It does, but there's a new problem: it sometimes crashes in the collect_connections thread during

Re: [PATCH try4] wininet: Added support for persistent HTTP connections

2011-05-06 Thread Jacek Caban
On 05/06/11 10:47, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: [PATCH try4] wininet: Added support for persistent HTTP connections

2011-05-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10757 Your paranoid android