Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.

2010-12-22 Thread jacek
On 12/22/10 2:17 PM, David Hedberg wrote: > Hi Jacek, > On Wed, Dec 22, 2010 at 13:07, Jacek Caban wrote: >>> +if(security_problem) { >>> +hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, >> You shouldn't need the cast here. > I get warnings if I leave the casts out tho

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.

2010-12-22 Thread David Hedberg
Hi Jacek, On Wed, Dec 22, 2010 at 13:07, Jacek Caban wrote: >> +    if(security_problem) { >> +        hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, > > You shouldn't need the cast here. > I get warnings if I leave the casts out though, and I can't see any obvious problem wi

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.

2010-12-22 Thread Jacek Caban
Hi David, On 12/22/10 12:50 AM, David Hedberg wrote: --- dlls/urlmon/http.c | 99 +-- dlls/urlmon/tests/url.c | 25 2 files changed, 120 insertions(+), 4 deletions(-) diff --git a/dlls/urlmon/http.c b/dlls/urlmon/http.c index