"Vincent Povirk" <[EMAIL PROTECTED]> wrote:
Again StrCpyNW is a shlwapi export, and since you just allocated the buffer
of correct length memcpy + adding an explicit '\0' terminator look more
naturally here (if not kernel32.lstrcpynW).
I'm allowed to use memcpy? Isn't that a native Linux funct
> > Again StrCpyNW is a shlwapi export, and since you just allocated the
> > buffer of correct length memcpy + adding an explicit '\0' terminator look
> > more naturally here (if not kernel32.lstrcpynW).
>
> I'm allowed to use memcpy? Isn't that a native Linux function?
It's a C library function.
> You are still using a buffer of a fixed size.
Whoops, didn't think about that one.
> StrRChrW is a shlwapi export. Since shlwapi.dll is just mostly a
> wrapper/helper,
> and it imports shell32, that would create a circular dependency. I already
> suggested to use strrchrW here.
Um, ok. I didn
"Vincent Povirk" <[EMAIL PROTECTED]> wrote:
fixes bug 9523, Knytt Stories installer fails
+/***
+ * SHPathPrepareForWriteA (SHELL32.@)
+ */
+HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPC
It appears Wine's SHCreateDirectoryEx is the same as Windows XP in the
way that matters to me: both return ERROR_ALREADY_EXISTS whether the
thing that already exists is a file or a directory. I haven't found a
situation where either version returns ERROR_FILE_EXISTS.
On 9/2/07, Dmitry Timoshkov <[
"Vincent Povirk" <[EMAIL PROTECTED]> wrote:
Well, I COULD do that if SHCreateDirectoryExW worked the way the Wine
API docs claim. It seems to be returning ERROR_ALREADY_EXISTS even
when the thing that already exists is a file and not a directory.
Then it needs a separate test case and a fix.
On 9/2/07, Vincent Povirk <[EMAIL PROTECTED]> wrote:
> On 9/2/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> > By checking return value of SHCreateDirectoryExW you can make a shortcut
> > in the deciding logic, in both cases: when the function fails you exit
> > right away (returning *correct* e
On 9/2/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> "Vincent Povirk" <[EMAIL PROTECTED]> wrote:
>
> >> Why there is no check for SHCreateDirectoryExW return value?
> > The return value of SHCreateDirectoryExW doesn't matter. All that
> > matters is whether the directory exists when the functio
"Vincent Povirk" <[EMAIL PROTECTED]> wrote:
Why there is no check for SHCreateDirectoryExW return value?
The return value of SHCreateDirectoryExW doesn't matter. All that
matters is whether the directory exists when the function returns. It
may or may not have existed when the function was call
On 9/2/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> It's better to not use fixed buffer sizes but allocate the buffer dynamically.
OK. I avoided that because I didn't want to have to worry about
freeing the buffer later when it's only needed in some cases.
> If the job must be done only when
"Vincent Povirk" <[EMAIL PROTECTED]> wrote:
HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPCSTR
path, DWORD flags)
{
-FIXME("%p %p %s 0x%08x\n", hwnd, modless, debugstr_a(path), flags);
-return S_OK;
+WCHAR wpath[MAX_PATH];
+MultiByteToWideChar( CP_ACP,
11 matches
Mail list logo
