Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); >>> +if (fd == -1) >>> +{ >>> +SetLastError(WSAENOTSOCK); >>> +return

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Bruno Jesus
On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); >> +if (fd == -1) >> +{ >> +SetLastError(WSAENOTSOCK); >> +return SOCKET_ERROR; >> +} >> +release_sock_fd( s, f

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); > +if (fd == -1) > +{ > +SetLastError(WSAENOTSOCK); > +return SOCKET_ERROR; > +} > +release_sock_fd( s, fd ); You should avoid retrieving the fd if you are not using it. The

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2062 Your paranoid andr