Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

2011-06-28 Thread Lucas Zawacki
The new patches address this issue, make some little corrections that are pointed in the comments. Also I organized them better, with the tests first. 2011/6/28 Lucas Zawacki : >> Do you really need to copy it back?  It looks like an input parameter. > > Yes, you're right. In SetActionMap this co

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

2011-06-28 Thread Lucas Zawacki
> Do you really need to copy it back? It looks like an input parameter. Yes, you're right. In SetActionMap this copy should not be necessary. I'll take this code out and roll a new version of the patches.

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

2011-06-28 Thread Alexandre Julliard
Lucas Fialho Zawacki writes: > +FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, > dwFlags); > + > +diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, > sizeof(DIACTIONW)*lpdiaf->dwNumActions); > +_copy_diactionformatAtoW(&diafW, lpdiaf); > + > +hr = > IDir

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer.

2011-06-20 Thread Vitaliy Margolen
On 06/20/2011 04:06 PM, Lucas Fialho Zawacki wrote: @@ -1391,9 +1391,24 @@ HRESULT WINAPI IDirectInputDevice8AImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface LPCSTR lpszUserName, DWORD dwFlags