Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Juan Lang
> Test can't be easily added to wine because we don't have pages to test > certificate errors on. That should be addressed, no? E.g. with a page hosted at winehq.org with a self-signed certificate? That'd at least allow us to check the expected error when the root of a certificate chain is untru

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Piotr Caban
Hi, On 05/19/10 02:01, Juan Lang wrote: +if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT) && ( +res == ERROR_INTERNET_SEC_CERT_DATE_INVALID +|| res == ERROR_INTERNET_INVALID_CA +|| res == ERROR_INTERNET_SEC_C

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

2010-05-18 Thread Juan Lang
Hi Piotr, +if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT) && ( +res == ERROR_INTERNET_SEC_CERT_DATE_INVALID +|| res == ERROR_INTERNET_INVALID_CA +|| res == ERROR_INTERNET_SEC_CERT_NO_REV +|