Re: [PATCH 3/4] msi: automation: Generalize list implementation.

2007-05-18 Thread Andrew Talbot
Misha Koshelev wrote: > So is the general recommendation for wine that we not use Hungarian > notation then? > > Misha IMHO, a prefix is of little value if it merely echos the declared type of the variable it represents, especially in a small-scope situation. To be of value, a prefix needs to co

Re: [PATCH 3/4] msi: automation: Generalize list implementation.

2007-05-18 Thread Stefan Dösinger
Am Freitag 18 Mai 2007 23:17 schrieb Misha Koshelev: > On Fri, 2007-05-18 at 20:15 +0200, Alexandre Julliard wrote: > > Misha Koshelev <[EMAIL PROTECTED]> writes: > > > if (wFlags & DISPATCH_PROPERTYGET) { > > > V_VT(pVarResult) = VT_I4; > > > -V_I4(pVa

Re: [PATCH 3/4] msi: automation: Generalize list implementation.

2007-05-18 Thread Misha Koshelev
On Fri, 2007-05-18 at 20:15 +0200, Alexandre Julliard wrote: > Misha Koshelev <[EMAIL PROTECTED]> writes: > > > if (wFlags & DISPATCH_PROPERTYGET) { > > V_VT(pVarResult) = VT_I4; > > -V_I4(pVarResult) = data->iCount; > > +V_I4(pVarResul

Re: [PATCH 3/4] msi: automation: Generalize list implementation.

2007-05-18 Thread Alexandre Julliard
Misha Koshelev <[EMAIL PROTECTED]> writes: > if (wFlags & DISPATCH_PROPERTYGET) { > V_VT(pVarResult) = VT_I4; > -V_I4(pVarResult) = data->iCount; > +V_I4(pVarResult) = data->ulCount; I committed this patch, but I can't resist pointing