Re: [PATCH 3/4] mshtml: Add helper function get_url_components

2009-09-28 Thread Andrew Eikum
Detlef Riekenberg wrote: On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW *url) +{ +const WCHAR *doc_url; +if(!InternetCrackUrlW(doc_url, 0, 0, url)) { +FIXME("InternetCrackUrlW failed\n"); Such a FI

Re: [PATCH 3/4] mshtml: Add helper function get_url_components

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW > *url) > +{ > +const WCHAR *doc_url; > +if(!InternetCrackUrlW(doc_url, 0, 0, url)) { > +FIXME("InternetCrackUrlW failed\n"); Such a FIXME does not help t