Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-08 Thread Joel Holdsworth
> > Does it fix a bug? If not, AJ may have placed it aside until after Wine 1.2 > > is released. > > Indeed. Adding new strings to translate will/should probably have to > wait until after Wine 1.2, so we can get as many languages as possible > at 100% when 1.2 is released. > > OTOH, if it new s

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-08 Thread Joel Holdsworth
> It says apply failure for 3/3, so that's probably why 2/3 wasn't committed > also. > > Problem is that there are a lot of translation updates these days and > some patches affect winecfg .rc files. I guess you should rebase on > git head and resend patch. However, I see there is still one patch

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-08 Thread Frédéric Delanoy
On Tue, Jun 8, 2010 at 03:41, James McKenzie wrote: > Joel Holdsworth wrote: >> >> On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: >> >>> >>> Signed-off-by: Joel Holdsworth >>> --- >>>  programs/winecfg/Bg.rc        |   19 + >>> >>> >> >> Any thoughts about this patch? I guess t

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-07 Thread Octavian Voicu
On Tue, Jun 8, 2010 at 1:17 AM, Joel Holdsworth wrote: > Any thoughts about this patch? I guess there's a reason why 1/3 was > merged but not 2/3 and 3/3. Anything I can fix? It says apply failure for 3/3, so that's probably why 2/3 wasn't committed also. Problem is that there are a lot of trans

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-07 Thread James McKenzie
Joel Holdsworth wrote: On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: Signed-off-by: Joel Holdsworth --- programs/winecfg/Bg.rc| 19 + Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel

2010-06-07 Thread Joel Holdsworth
On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth > --- > programs/winecfg/Bg.rc| 19 + > programs/winecfg/Cs.rc| 19 + > programs/winecfg/Da.rc| 19 + > programs/winecfg/De.rc| 19 + >