Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements

2011-03-03 Thread Alexandre Julliard
Jacek Caban writes: > On 3/3/11 2:45 PM, Alexandre Julliard wrote: >> Jacek Caban writes: >> >>> +/* FIXME: Implement in more generic and safe way */ >>> +for(ptr = name; *ptr&& isdigitW(*ptr); ptr++) >>> +i = i*10 + (*ptr-'0'); >> What's wrong with strtoulW? > > We don't want t

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements

2011-03-03 Thread Jacek Caban
On 3/3/11 2:45 PM, Alexandre Julliard wrote: Jacek Caban writes: +/* FIXME: Implement in more generic and safe way */ +for(ptr = name; *ptr&& isdigitW(*ptr); ptr++) +i = i*10 + (*ptr-'0'); What's wrong with strtoulW? We don't want to use strings like "+1" or with leasing sp

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements

2011-03-03 Thread Alexandre Julliard
Jacek Caban writes: > +/* FIXME: Implement in more generic and safe way */ > +for(ptr = name; *ptr && isdigitW(*ptr); ptr++) > +i = i*10 + (*ptr-'0'); What's wrong with strtoulW? -- Alexandre Julliard julli...@winehq.org